From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v6 00/22] XSA55 libelf fixes for unstable
Date: Tue, 11 Jun 2013 00:44:31 +0100
Message-ID: <51B664DF.6090500@citrix.com>
References: <1370629642-6990-1-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1370629642-6990-1-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "mattjd@gmail.com" <mattjd@gmail.com>, "security@xen.org" <security@xen.org>
List-Id: xen-devel@lists.xenproject.org

Ok,

So after a bit of a marathon code review (I am fairly sure I started
more than 12 hours ago)

Patches 1,4-9,13 and 17 seem fine, so please consider them

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

All other patches have comments or queries in the emails.  Because of
the order of my review, and where I noticed issues, the point at which I
commented might not be the correct place to fix the issue, and some of
the comments might appear strange when reading the series in order.  My
apologies.  Some of the queries can validly be answers with "that should
be left to general bugfixing", but I decided to mention all points I
discovered.

~Andrew