From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: fix initialization of wallclock time for PVHVM on migration
Date: Tue, 11 Jun 2013 14:17:58 +0200 [thread overview]
Message-ID: <51B71576.1080009@citrix.com> (raw)
In-Reply-To: <51B72D3602000078000DD0FD@nat28.tlf.novell.com>
On 11/06/13 13:59, Jan Beulich wrote:
>>>> On 11.06.13 at 12:46, Roger Pau Monne <roger.pau@citrix.com> wrote:
>> The initial values of the wallclock time in the shared info page are
>> set for PVHVM guests when the hypercall page is initialized, since the
>> hypercall page is not reinitialized on resume, the hypervisor
>> wallclock time is not properly set on resume.
>>
>> Fix it by forcing an update of the wallclock values when the shared
>> info page is mapped.
>
> NACK - this is a guest side bug. After migration, a guest _has_ to
> re-init the hypercall page, as it may have got migrated between
> a VMX and an SVM machine, and the hypercall instructions are
> different between them.
AFAICS Linux doesn't seem to re-init the hypercall page, see
xen_arch_hvm_post_suspend at arch/x86/xen/suspend.c, but maybe I'm
missing something.
next prev parent reply other threads:[~2013-06-11 12:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 10:46 [PATCH] xen: fix initialization of wallclock time for PVHVM on migration Roger Pau Monne
2013-06-11 11:59 ` Jan Beulich
2013-06-11 12:01 ` George Dunlap
2013-06-11 12:12 ` Jan Beulich
2013-06-11 13:59 ` Ian Campbell
2013-06-11 14:04 ` Jan Beulich
2013-06-12 13:36 ` Egger, Christoph
2013-06-11 12:17 ` Roger Pau Monné [this message]
2013-06-11 13:15 ` konrad wilk
2013-06-11 14:02 ` Jan Beulich
2013-06-11 13:38 ` Roger Pau Monné
2013-06-11 14:16 ` Jan Beulich
2013-06-11 14:41 ` Konrad Rzeszutek Wilk
2013-06-11 15:05 ` Keir Fraser
2013-06-11 15:45 ` Keir Fraser
2013-06-11 15:59 ` Roger Pau Monné
2013-06-11 16:12 ` Keir Fraser
2013-06-11 16:14 ` Roger Pau Monné
2013-06-11 15:59 ` Jan Beulich
2013-06-12 13:50 ` Konrad Rzeszutek Wilk
2013-06-12 13:55 ` Roger Pau Monné
2013-06-11 15:50 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B71576.1080009@citrix.com \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).