From: Ross Philipson <ross.philipson@citrix.com>
To: xen-devel@lists.xen.org
Cc: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH 5/5] xen: Add V4V implementation - padding question
Date: Tue, 11 Jun 2013 13:40:37 -0400 [thread overview]
Message-ID: <51B76115.7000209@citrix.com> (raw)
In-Reply-To: <20130611172507.GC27333@ocelot.phlegethon.org>
On 06/11/2013 01:25 PM, Tim Deegan wrote:
> At 13:10 -0400 on 11 Jun (1370956242), Ross Philipson wrote:
>>>
>>>>> ...
>>>>> +struct v4v_info
>>>>> +{
>>>>> + uint64_t ring_magic;
>>>>> + uint64_t data_magic;
>>>>> + evtchn_port_t evtchn;
>>>>
>>>> Missing padding at the end?
>>>>
>>>
>>> ack.
>>>
>>
>> At one point during the review of an earlier version of the V4V patch
>> set, Jan requested that this pad be added to the v4v_info struct. I
>> understand the padding in all the other structs but I don't understand
>> this one. This struct is not included in any other structs and is not
>> followed by any data.
>
> 64-bit Xen would see this as a 24-byte struct, even without explicit
> padding. That would surprise a 32-bit guest that allocated what it saw
> as a 20-byte struct for Xen to copy into.
Ah yes, of course. Thanks for the quick response.
Ross
>
> Tim.
next prev parent reply other threads:[~2013-06-11 17:40 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 19:50 [PATCH 0/5] RFC: V4V (v3) Jean Guyader
2012-08-03 19:50 ` [PATCH 1/5] xen: add ssize_t Jean Guyader
2012-08-06 8:08 ` Jan Beulich
2012-08-06 14:47 ` Jean Guyader
2012-08-09 9:51 ` Tim Deegan
2012-08-09 10:19 ` Jean Guyader
2012-08-09 10:39 ` Jan Beulich
2012-08-09 10:48 ` Jean Guyader
2012-08-09 13:02 ` Jan Beulich
2012-08-09 10:59 ` Tim Deegan
2012-08-09 11:08 ` Jean Guyader
2012-08-03 19:50 ` [PATCH 2/5] xen: Introduce guest_handle_for_field Jean Guyader
2012-08-03 19:50 ` [PATCH 3/5] xen: virq, remove VIRQ_XC_RESERVED Jean Guyader
2012-08-06 8:10 ` Jan Beulich
2012-08-06 14:46 ` Jean Guyader
2012-08-06 14:49 ` Andrew Cooper
2012-08-06 14:56 ` Ian Campbell
2012-08-06 15:01 ` Jean Guyader
2012-08-06 15:13 ` Ian Campbell
2012-08-06 15:46 ` Jan Beulich
2012-08-03 19:50 ` [PATCH 4/5] xen: events, exposes evtchn_alloc_unbound_domain Jean Guyader
2012-08-06 8:19 ` Jan Beulich
2012-08-09 10:06 ` Tim Deegan
2012-08-09 10:23 ` Ian Campbell
2012-08-09 10:35 ` Tim Deegan
2012-08-09 10:40 ` Jean Guyader
2012-08-09 23:25 ` Jean Guyader
2012-08-10 7:35 ` Jan Beulich
2012-08-10 7:51 ` Jean Guyader
2012-08-10 7:57 ` Jan Beulich
2012-08-23 12:03 ` Jean Guyader
2012-08-03 19:50 ` [PATCH 5/5] xen: Add V4V implementation Jean Guyader
2012-08-06 8:45 ` Jan Beulich
2012-08-23 11:57 ` Jean Guyader
2012-08-24 20:06 ` Jan Beulich
2012-09-01 20:58 ` Jean Guyader
2012-09-01 20:56 ` Jean Guyader
2013-06-11 17:10 ` [PATCH 5/5] xen: Add V4V implementation - padding question Ross Philipson
2013-06-11 17:25 ` Tim Deegan
2013-06-11 17:40 ` Ross Philipson [this message]
2013-06-11 17:54 ` Ross Philipson
2013-06-11 18:04 ` Tim Deegan
2013-06-12 7:45 ` Jan Beulich
2013-06-13 17:21 ` Stefano Stabellini
2012-08-09 10:38 ` [PATCH 5/5] xen: Add V4V implementation Tim Deegan
2012-08-10 16:51 ` Jean Guyader
2012-08-13 9:38 ` Tim Deegan
2012-08-13 12:43 ` Jean Guyader
2012-08-16 12:32 ` Tim Deegan
2012-08-04 13:24 ` [PATCH 0/5] RFC: V4V (v3) Jean Guyader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B76115.7000209@citrix.com \
--to=ross.philipson@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).