From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Frediano Ziglio <frediano.ziglio@citrix.com>,
Christoph Egger <chegger@amazon.de>,
Miguel Clara <miguelmclara@gmail.com>,
Frediano Ziglio <frediano.ziglio@citrite.net>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/misc/xencov.c: Use MAP_WIRED on NetBSD
Date: Wed, 12 Jun 2013 14:13:02 +0100 [thread overview]
Message-ID: <51B873DE.5030109@eu.citrix.com> (raw)
In-Reply-To: <1371039293.24512.425.camel@zakaz.uk.xensource.com>
On 12/06/13 13:14, Ian Campbell wrote:
> On Wed, 2013-06-12 at 13:02 +0100, Frediano Ziglio wrote:
>> Subject: [PATCH] gcov: Do not use mmap directly but use xc_hypercall_buffer_alloc
>>
>> xencov.c did not compile on NetBSD so use xc_hypercall_buffer which is
>> more portable.
>>
>> Signed-off-by: Frediano Ziglio <frediano.ziglio@citrix.com>
> Looks good to me, thanks,
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> George, what is your feeling for the release? This is a somewhat obscure
> tool and IMHO the risk of regressing is small. The change fixes the
> default build on NetBSD.
Did we even have gcov in 4.2? Anyway I agree, the benefits are worth
more than the risk.
Re the release:
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
-George
next prev parent reply other threads:[~2013-06-12 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 12:46 [PATCH] tools/misc/xencov.c: Use MAP_WIRED on NetBSD Christoph Egger
2013-05-31 11:25 ` Ian Campbell
2013-06-11 13:46 ` Frediano Ziglio
2013-06-12 9:21 ` Ian Campbell
2013-06-12 12:02 ` Frediano Ziglio
2013-06-12 12:14 ` Ian Campbell
2013-06-12 13:13 ` George Dunlap [this message]
2013-06-12 13:16 ` Ian Campbell
2013-06-12 15:25 ` Frediano Ziglio
2013-06-27 11:31 ` Ian Campbell
2013-06-13 9:47 ` Egger, Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B873DE.5030109@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=chegger@amazon.de \
--cc=frediano.ziglio@citrite.net \
--cc=frediano.ziglio@citrix.com \
--cc=miguelmclara@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).