From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] tools/misc/xencov.c: Use MAP_WIRED on NetBSD Date: Wed, 12 Jun 2013 14:13:02 +0100 Message-ID: <51B873DE.5030109@eu.citrix.com> References: <51A74A37.5070502@amazon.de> <1369999519.5199.99.camel@zakaz.uk.xensource.com> <1370958416.1654.3.camel@hamster.uk.xensource.com> <1371028899.24512.376.camel@zakaz.uk.xensource.com> <1371038547.26497.4.camel@hamster.uk.xensource.com> <1371039293.24512.425.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1371039293.24512.425.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Frediano Ziglio , Christoph Egger , Miguel Clara , Frediano Ziglio , xen-devel List-Id: xen-devel@lists.xenproject.org On 12/06/13 13:14, Ian Campbell wrote: > On Wed, 2013-06-12 at 13:02 +0100, Frediano Ziglio wrote: >> Subject: [PATCH] gcov: Do not use mmap directly but use xc_hypercall_buffer_alloc >> >> xencov.c did not compile on NetBSD so use xc_hypercall_buffer which is >> more portable. >> >> Signed-off-by: Frediano Ziglio > Looks good to me, thanks, > > Acked-by: Ian Campbell > > George, what is your feeling for the release? This is a somewhat obscure > tool and IMHO the risk of regressing is small. The change fixes the > default build on NetBSD. Did we even have gcov in 4.2? Anyway I agree, the benefits are worth more than the risk. Re the release: Acked-by: George Dunlap -George