From: George Dunlap <george.dunlap@eu.citrix.com>
To: "Egger, Christoph" <chegger@amazon.de>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xentrace: Correct PV trace dump
Date: Thu, 13 Jun 2013 15:33:07 +0100 [thread overview]
Message-ID: <51B9D823.7030804@eu.citrix.com> (raw)
In-Reply-To: <51B9D6D4.4020703@amazon.de>
On 13/06/13 15:27, Egger, Christoph wrote:
> On 13.06.13 16:17, George Dunlap wrote:
>> On 13/06/13 11:51, Egger, Christoph wrote:
>>> On 13.06.13 12:39, Andrew Cooper wrote:
>>>> On 13/06/13 11:22, Christoph Egger wrote:
>>>>> commit c1855d1ad8c5ce218b5ef6825401dc985a3d1f4d
>>>>> Author: Christoph Egger <chegger@amazon.de>
>>>>> Date: Fri May 24 11:33:38 2013 +0000
>>>>>
>>>>> xentrace: Correct PV trace dump
>>>>> Signed-off-by: Christoph Egger <chegger@amazon.de>
>>>> Can you describe in the commit message what you are changing and why?
>>> Without this patch the PV traces are not decoded at all
>>> as the identifier is wrong.
>>>
>>> This patch makes the identifier match with
>>> xen/include/public/trace.h and the PV traces get decoded correctly.
>> I think he was asking you to re-send the patch with a more descriptive
>> commit message.
> Done.
No, not really.
What you wrote above is starting to become a descriptive message -- what
you put in the re-sent patch is basically nothing. You need to write
what the problem was, and and also the technical thing that you are doing.
In particular, in this case, a whole series of trace records in
xentrace_format have "1" for the subclass field, when they should have "f".
-George
prev parent reply other threads:[~2013-06-13 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 10:22 [PATCH] xentrace: Correct PV trace dump Christoph Egger
2013-06-13 10:39 ` Andrew Cooper
2013-06-13 10:51 ` Egger, Christoph
2013-06-13 14:17 ` George Dunlap
2013-06-13 14:27 ` Egger, Christoph
2013-06-13 14:33 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9D823.7030804@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chegger@amazon.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).