From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] xentrace: Correct PV trace dump Date: Thu, 13 Jun 2013 15:33:07 +0100 Message-ID: <51B9D823.7030804@eu.citrix.com> References: <51B99D77.8000303@amazon.de> <51B9A16D.30006@citrix.com> <51B9A44D.3040406@amazon.de> <51B9D45F.8010707@eu.citrix.com> <51B9D6D4.4020703@amazon.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51B9D6D4.4020703@amazon.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Egger, Christoph" Cc: Andrew Cooper , xen-devel List-Id: xen-devel@lists.xenproject.org On 13/06/13 15:27, Egger, Christoph wrote: > On 13.06.13 16:17, George Dunlap wrote: >> On 13/06/13 11:51, Egger, Christoph wrote: >>> On 13.06.13 12:39, Andrew Cooper wrote: >>>> On 13/06/13 11:22, Christoph Egger wrote: >>>>> commit c1855d1ad8c5ce218b5ef6825401dc985a3d1f4d >>>>> Author: Christoph Egger >>>>> Date: Fri May 24 11:33:38 2013 +0000 >>>>> >>>>> xentrace: Correct PV trace dump >>>>> Signed-off-by: Christoph Egger >>>> Can you describe in the commit message what you are changing and why? >>> Without this patch the PV traces are not decoded at all >>> as the identifier is wrong. >>> >>> This patch makes the identifier match with >>> xen/include/public/trace.h and the PV traces get decoded correctly. >> I think he was asking you to re-send the patch with a more descriptive >> commit message. > Done. No, not really. What you wrote above is starting to become a descriptive message -- what you put in the re-sent patch is basically nothing. You need to write what the problem was, and and also the technical thing that you are doing. In particular, in this case, a whole series of trace records in xentrace_format have "1" for the subclass field, when they should have "f". -George