From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: patches@linaro.org, Stefano.Stabellini@eu.citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v4] xen/arm: Rework the way to compute dom0 DTB base address
Date: Thu, 13 Jun 2013 17:11:07 +0100 [thread overview]
Message-ID: <51B9EF1B.5000106@linaro.org> (raw)
In-Reply-To: <1371139117.6955.34.camel@zakaz.uk.xensource.com>
On 06/13/2013 04:58 PM, Ian Campbell wrote:
> On Mon, 2013-06-03 at 14:57 +0100, Julien Grall wrote:
>> + /*
>> + * Check the kernel won't overlap the kernel
>> + * Only when it's a ZIMAGE
>> + */
>> + if ( kinfo->ktype != KERNEL_ZIMAGE )
>> + return;
>
> It occurs to me that we could avoid needing this and the associated
> gubbins to remember the type of kernel by having a ->check function hook
> alongside the ->load hook and only setting it for zImage.
>
> What do you think?
Sounds good to me. I will update the patch with this solution.
--
Julien
prev parent reply other threads:[~2013-06-13 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:57 [PATCH v4] xen/arm: Rework the way to compute dom0 DTB base address Julien Grall
2013-06-13 15:58 ` Ian Campbell
2013-06-13 16:11 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9EF1B.5000106@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).