From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4] xen/arm: Rework the way to compute dom0
	DTB base address
Date: Thu, 13 Jun 2013 17:11:07 +0100
Message-ID: <51B9EF1B.5000106@linaro.org>
References: <1370267861-23051-1-git-send-email-julien.grall@linaro.org>
	<1371139117.6955.34.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1371139117.6955.34.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: patches@linaro.org, Stefano.Stabellini@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 06/13/2013 04:58 PM, Ian Campbell wrote:

> On Mon, 2013-06-03 at 14:57 +0100, Julien Grall wrote:
>> +    /*
>> +     * Check the kernel won't overlap the kernel
>> +     * Only when it's a ZIMAGE
>> +     */
>> +    if ( kinfo->ktype != KERNEL_ZIMAGE )
>> +        return;
> 
> It occurs to me that we could avoid needing this and the associated
> gubbins to remember the type of kernel by having a ->check function hook
> alongside the ->load hook and only setting it for zImage.
> 
> What do you think?

Sounds good to me. I will update the patch with this solution.

-- 
Julien