xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Frediano Ziglio <frediano.ziglio@citrix.com>
Cc: Matthew Daley <mattjd@gmail.com>,
	Christoph Egger <chegger@amazon.de>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Miguel Clara <miguelmclara@gmail.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] gcov: Support gcc 4.7
Date: Tue, 18 Jun 2013 15:53:21 +0100	[thread overview]
Message-ID: <51C07461.606@eu.citrix.com> (raw)
In-Reply-To: <1371565974.12598.39.camel@hamster.uk.xensource.com>

On 06/18/2013 03:32 PM, Frediano Ziglio wrote:
> On Mon, 2013-06-17 at 11:49 +0100, Ian Campbell wrote:
>> On Mon, 2013-06-17 at 11:46 +0100, Frediano Ziglio wrote:
>>> Perhaps a simple easy solution would be to allow privileged domains to
>>> read/write arbitrary memory from Xen (write to reset counters).
>>
>> "Arbitrary memory" would be a very hard sell.
>>
>> If all these counters could be constrained to pages which contains these
>> counters and nothing else then that might be a possibility to consider.
>>
>> Ian.
>>
>
> It depends on how this would be implemented. A future option of gcc
> could help at least having everything in contiguous memory regions.
>
> The fact that these information are generated by the compiler does not
> help that much. Every version could change the format "slightly" but
> enough to make Xen core when such information are requested!
>
> Actually they changed format for these version of gcc:
> - 3.3
> - 3.4
> - 4.7
>
> And honestly I still don't understand clearly why they changed for gcc
> 4.7! Probably not for a C feature but to support C++ templates and
> comdat. A "smart" preprocessor sit in the middle of gcc and gas that
> process assembly generated, check for structures and put everything in
> different sections could really help... but is not that easy project!
> Another similar way would be to parse the xen-syms output file and
> generate needed blob/code. Quite interesting challenge (I did more
> terrible things then this) but I don't thing that Citrix would agree.
> Possibly a safe thing to do would be in the code to check that compiler
> is really gcc and that we can support the version that is compiling,
> just to make sure. But is also true that this feature is a debug one
> disabled on production so I don't know how worth would be.
>
> Not speaking of clang support, currently quite hard (the structures are
> less documented, the code hooks destructors path which is not safe to
> call from Xen code which is not expected to terminate).

Doesn't Linux have gcov support via lcov?  Do they have to deal with 
this stuff as well, or is there a generic way to deal with it?

  -George

  reply	other threads:[~2013-06-18 14:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17  8:29 [PATCH] gcov: Support gcc 4.7 Frediano Ziglio
2013-06-17  8:58 ` Jan Beulich
2013-06-28 10:18   ` Frediano Ziglio
2013-06-28 10:26     ` Jan Beulich
2013-06-17  9:50 ` George Dunlap
2013-06-17 10:42 ` Ian Campbell
2013-06-17 10:46   ` Frediano Ziglio
2013-06-17 10:49     ` Ian Campbell
2013-06-17 12:25       ` Frediano Ziglio
2013-06-18 14:32       ` Frediano Ziglio
2013-06-18 14:53         ` George Dunlap [this message]
2013-06-18 15:04           ` Frediano Ziglio
2013-06-17 10:49   ` Egger, Christoph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C07461.606@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=chegger@amazon.de \
    --cc=frediano.ziglio@citrix.com \
    --cc=mattjd@gmail.com \
    --cc=miguelmclara@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).