From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments Date: Fri, 21 Jun 2013 09:37:38 +0100 Message-ID: <51C410D2.6060607@eu.citrix.com> References: <1371746007-19073-1-git-send-email-george.dunlap@eu.citrix.com> <1371746007-19073-2-git-send-email-george.dunlap@eu.citrix.com> <20931.14127.431627.799759@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20931.14127.431627.799759@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Keir Fraser , Ian Campbell , Hanweidong , Stefano Stabellini , xen-devel@lists.xen.org, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 20/06/13 18:09, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH v3 1/8] hvmloader: Remove all 64-bit print arguments"): >> What's the issue with implementing %llx? > Isn't this an endless series of just-before-release yaks ? > > If it were me I would have left the %llx alone. I needed to print the 64-bit values for diagnostic purposes, particularly when testing boundary conditions; that's why I did the manual break-down. Changing the faked-up printf to handle uint64_t wasn't too difficult, but it required implementing a 64-bit integer division, which was more than I was up for. -George