From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v3 1/8] hvmloader: Remove all 64-bit print
	arguments
Date: Fri, 21 Jun 2013 10:22:39 +0100
Message-ID: <51C41B5F.2020707@eu.citrix.com>
References: <1371746007-19073-1-git-send-email-george.dunlap@eu.citrix.com>
	<1371746007-19073-2-git-send-email-george.dunlap@eu.citrix.com>
	<alpine.DEB.2.02.1306201802460.4548@kaball.uk.xensource.com>
	<51C41027.4080605@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51C41027.4080605@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Hanweidong <hanweidong@huawei.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Jackson <ian.jackson@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 21/06/13 09:34, George Dunlap wrote:
> On 20/06/13 18:06, Stefano Stabellini wrote:
>> On Thu, 20 Jun 2013, George Dunlap wrote:
>>> The printf() available to hvmloader does not handle 64-bit data types;
>>> manually break them down as two 32-bit strings.
>>>
>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>>> CC: Ian Campbell <ian.campbell@citrix.com>
>>> CC: Ian Jackson <ian.jackson@citrix.com>
>>> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
>>> CC: Hanweidong <hanweidong@huawei.com>
>>> CC: Keir Fraser <keir@xen.org>
>> What's the issue with implementing %llx?
>
> It involves implementing __udiv64(), since hvmloader runs in 32-bit mode.

Actually, it looks like hvmloader already does have a "divide 64-bit by 
32-bit" function I could use; but that would be a more significant 
change in functionality in the paths that are run by basically everyone, 
rather than minimal changes for people not affected by the bug and major 
changes only for people who are going to crash anyway.

  -George