From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] tools/libxc: Fix memory leaks in
	xc_domain_restore()
Date: Fri, 21 Jun 2013 18:30:25 +0100
Message-ID: <51C48DB1.2030800@citrix.com>
References: <cec58839d6eff0ac27de.1371832586@andrewcoop.uk.xensource.com>
	<20932.36093.15692.139649@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20932.36093.15692.139649@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 21/06/13 18:27, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH] tools/libxc: Fix memory leaks in xc_domain_restore()"):
>> tools/libxc: Fix memory leaks in xc_domain_restore()
>> +    free(region_mfn);
> ...
>> +    pagebuf_free(&pagebuf);
> These look correct to me.
>
> But as regards
>
>> +    free(ctx->p2m_batch);
> It's not clear to me where that's initialised.  It needs to be
> initialised to NULL I think.
>
> Ian.

It is initialised in memset(ctx, 0, sizeof(*ctx)) at the top of the
function.

~Andrew