From mboxrd@z Thu Jan  1 00:00:00 1970
From: DuanZhenzhong <zhenzhong.duan@oracle.com>
Subject: Re: [PATCH 4.1] x86: fix emuirq regression from XSA-21
	fix
Date: Tue, 25 Jun 2013 16:43:04 +0800
Message-ID: <51C95818.2040106@oracle.com>
References: <alpine.DEB.2.02.1305131753070.4799@kaball.uk.xensource.com>
	<20130514142013.GA10173@konrad-lan.dumpdata.com>
	<alpine.DEB.2.02.1305151037100.4799@kaball.uk.xensource.com>
	<5195944A.3050608@oracle.com>
	<alpine.DEB.2.02.1305201121370.4799@kaball.uk.xensource.com>
	<20130520175706.GA27973@phenom.dumpdata.com>
	<20130520203855.GA30616@phenom.dumpdata.com>
	<519B474E.4000202@citrix.com>
	<20130521134059.GE492@phenom.dumpdata.com>
	<alpine.DEB.2.02.1305211748030.4799@kaball.uk.xensource.com>
	<alpine.DEB.2.02.1305291850030.4799@kaball.uk.xensource.com>
	<51AECC3A.7060803@oracle.com>
	<alpine.DEB.2.02.1306051349380.4589@kaball.uk.xensource.com>
	<51C26F98.8070103@oracle.com>
	<alpine.DEB.2.02.1306201507010.4548@kaball.uk.xensource.com>
	<51C7F2FE.3090803@oracle.com>
	<alpine.DEB.2.02.1306241807100.4782@kaball.uk.xensource.com>
	<51C92B8F.6010904@oracle.com>
	<51C9611802000078000E0336@nat28.tlf.novell.com>
	<51C94A4A.8050904@oracle.com>
	<51C9729F02000078000E03BA@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51C9729F02000078000E03BA@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Feng Jin <joe.jin@oracle.com>, Yuval Shaia <yuval.shaia@oracle.com>, Chien Yen <chien.yen@oracle.com>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Jan Beulich wrote:
>>>> On 25.06.13 at 09:44, DuanZhenzhong <zhenzhong.duan@oracle.com> wrote:
>>>>         
>> Any reason of not right? below patch does work as ret is already zero if it 
>> could get to that line.
>>
>> zduan
>>
>> ****************************************************
>> x86: fix emuirq regression from XSA-21 fix
>>
>> The XSA-21 patch broke the assumption of "ret" being zero prior to the
>> IRQ_UNBOUND check.
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>>
>> --- a/xen/arch/x86/physdev.c
>> +++ b/xen/arch/x86/physdev.c
>> @@ -240,7 +240,6 @@ static int physdev_unmap_pirq(struct phy
>>      if ( ret )
>>          return ret;
>>  
>> -    ret = -EINVAL;
>>      if ( unmap->pirq < 0 || unmap->pirq >= d->nr_pirqs )
>>          goto free_domain;
>>     
>
> So if unmap->pirq is out of range, you'd return 0 (success)
> nevertheless - how can that be correct?
>
> Jan
>
>   
You are right.

zduan