From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH V3] xen: Don't perform SMP setup.
Date: Wed, 26 Jun 2013 17:50:48 +0100 [thread overview]
Message-ID: <51CB1BE8.7000307@citrix.com> (raw)
In-Reply-To: <1372263867.7337.97.camel@zakaz.uk.xensource.com>
On 26/06/13 17:24, Ian Campbell wrote:
> On Mon, 2013-06-24 at 14:35 +0100, Anthony PERARD wrote:
>> This is not needed and in case one want to start a guest with fewer vCPU
>> than the maximum, the function will fail (infinite loop).
>>
>> It's a "backport" of 5dbf1732940f94771e0b3c45c0960940276bc263.
>
> For me this causes:
> src/smp.c: In function ‘smp_probe’:
> src/smp.c:87: warning: implicit declaration of function ‘usingXen’
> In file included from src/post.c:26:
> src/xen.h: At top level:
> src/xen.h:14: error: static declaration of ‘usingXen’ follows non-static declaration
> src/smp.c:87: note: previous implicit declaration of ‘usingXen’ was here
> (and a bunch more).
>
> I think you need a #include?
Yes, I sent another patch that fix it:
<1372260645-26944-1-git-send-email-anthony.perard@citrix.com>
Sorry for that.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-06-26 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 13:32 [PATCH v3 0/2] CPU hotplug for qemu-xen Anthony PERARD
2013-06-24 13:32 ` [PATCH v3 1/2] libxl: Add "cpu-add" QMP command Anthony PERARD
2013-06-24 16:00 ` George Dunlap
2013-06-24 13:33 ` [PATCH v3 2/2] libxl: Use QMP cpu-add to hotplug CPU with qemu-xen Anthony PERARD
2013-06-24 15:57 ` George Dunlap
2013-06-24 13:35 ` [PATCH V3] xen: Don't perform SMP setup Anthony PERARD
2013-06-26 16:24 ` Ian Campbell
2013-06-26 16:50 ` Anthony PERARD [this message]
2013-06-26 17:03 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CB1BE8.7000307@citrix.com \
--to=anthony.perard@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).