From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Marcos E. Matsunaga" Subject: Re: [PATCH] xend: Fix xm list bug reporting incorrect memory size Date: Thu, 27 Jun 2013 05:29:54 -0400 Message-ID: <51CC0612.50804@oracle.com> References: <1364924327-31151-1-git-send-email-konrad.wilk@oracle.com> <20130605190124.GA5470@u109add4315675089e695.ant.amazon.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030709070709090407040307" Return-path: In-Reply-To: <20130605190124.GA5470@u109add4315675089e695.ant.amazon.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matt Wilson Cc: xen-devel@lists.xensource.com, ian.campbell@citrix.com, Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------030709070709090407040307 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Matt, I have corrected the tab problem and re-created the patch. It is attached. From aec170275bef7f371d9a195f49a3e8790160dd0f Mon Sep 17 00:00:00 2001 From: Marcos Matsunaga Date: Thu, 27 Jun 2013 05:25:42 -0400 Subject: [PATCH] xend: Fix xm list bug reporting incorrect memory size This change allows xend to double-check the xcinfo info (which hypercall it had already do) and use the up-to-date contents. 'xl' already does this by using the xcinfo. Oracle-Bug: 14553104 ( MEM(K) IN XENTOP MISMATCH MEMTOTAL IN /PROC/MEMINFO AND MEM IN "XM LIST") Signed-off-by: Marcos Matsunaga Signed-off-by: Konrad Rzeszutek Wilk --- tools/python/xen/xend/XendConfig.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/python/xen/xend/XendConfig.py b/tools/python/xen/xend/XendConfig.py index 5568d35..eb433a7 100644 --- a/tools/python/xen/xend/XendConfig.py +++ b/tools/python/xen/xend/XendConfig.py @@ -1042,7 +1042,10 @@ class XendConfig(dict): @param dominfo: Domain information via xc.domain_getinfo() @type dominfo: dict """ - self._dominfo_to_xapi(dominfo) + if dominfo['paused']: + self._dominfo_to_xapi(dominfo) + else: + self._dominfo_to_xapi(dominfo, update_mem = True) self.validate() def update_with_xenapi_config(self, xapi): -- 1.8.1.2 On 06/05/2013 03:01 PM, Matt Wilson wrote: > This change allows xend to double-check the xcinfo info (which > >hypercall it had already do) and use the up-to-date contents. > > > >'xl' already does this by using the xcinfo. > > > >Oracle-Bug: 14553104 ( MEM(K) IN XENTOP MISMATCH MEMTOTAL IN /PROC/MEMINFO AND MEM IN "XM LIST") > >Signed-off-by: Marcos Matsunaga > >Signed-off-by: Konrad Rzeszutek Wilk --------------030709070709090407040307 Content-Type: text/x-patch; name="0001-xend-Fix-xm-list-bug-reporting-incorrect-memory-size.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-xend-Fix-xm-list-bug-reporting-incorrect-memory-size.pa"; filename*1="tch" >>From aec170275bef7f371d9a195f49a3e8790160dd0f Mon Sep 17 00:00:00 2001 From: Marcos Matsunaga Date: Thu, 27 Jun 2013 05:25:42 -0400 Subject: [PATCH] xend: Fix xm list bug reporting incorrect memory size This change allows xend to double-check the xcinfo info (which hypercall it had already do) and use the up-to-date contents. 'xl' already does this by using the xcinfo. Oracle-Bug: 14553104 ( MEM(K) IN XENTOP MISMATCH MEMTOTAL IN /PROC/MEMINFO AND MEM IN "XM LIST") Signed-off-by: Marcos Matsunaga Signed-off-by: Konrad Rzeszutek Wilk --- tools/python/xen/xend/XendConfig.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/python/xen/xend/XendConfig.py b/tools/python/xen/xend/XendConfig.py index 5568d35..eb433a7 100644 --- a/tools/python/xen/xend/XendConfig.py +++ b/tools/python/xen/xend/XendConfig.py @@ -1042,7 +1042,10 @@ class XendConfig(dict): @param dominfo: Domain information via xc.domain_getinfo() @type dominfo: dict """ - self._dominfo_to_xapi(dominfo) + if dominfo['paused']: + self._dominfo_to_xapi(dominfo) + else: + self._dominfo_to_xapi(dominfo, update_mem = True) self.validate() def update_with_xenapi_config(self, xapi): -- 1.8.1.2 --------------030709070709090407040307 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --------------030709070709090407040307--