From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 04/10] kexec: add infrastructure for handling kexec images
Date: Thu, 27 Jun 2013 18:17:12 +0100 [thread overview]
Message-ID: <51CC7398.3040202@citrix.com> (raw)
In-Reply-To: <51C968E002000078000E0386@nat28.tlf.novell.com>
On 25/06/13 08:54, Jan Beulich wrote:
>>>> On 24.06.13 at 19:42, David Vrabel <david.vrabel@citrix.com> wrote:
>>
>> + goto out;
>> +
>> + image->control_page = ~0; /* By default this does not apply */
>
> Use a recognizable #define instead?
This assignment serves no purpose so I'll leaved it zeroed.
>> + mstart = image->segments[i].dest_maddr;
>> + mend = mstart + image->segments[i].dest_size;
>> + if ( (mstart & ~PAGE_MASK) || (mend & ~PAGE_MASK) )
>
> Expressions like this can be abbreviated to
>
> if ( (mstart | mend) & ~PAGE_MASK )
I think the original more clearly reflects the intent.
David
next prev parent reply other threads:[~2013-06-27 17:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 17:42 [PATCHv6 0/10] kexec: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-06-24 17:42 ` [PATCH 01/10] x86: give FIX_EFI_MPF its own fixmap entry David Vrabel
2013-06-24 17:42 ` [PATCH 02/10] xen: make GUEST_HANDLE_64() and uint64_aligned_t available everywhere David Vrabel
2013-06-25 7:42 ` Jan Beulich
2013-06-25 9:42 ` David Vrabel
2013-06-25 11:36 ` Jan Beulich
2013-06-25 13:17 ` David Vrabel
2013-06-25 13:53 ` Jan Beulich
2013-06-25 14:48 ` David Vrabel
2013-06-25 15:02 ` Jan Beulich
2013-06-24 17:42 ` [PATCH 03/10] kexec: add public interface for improved load/unload sub-ops David Vrabel
2013-06-25 7:45 ` Jan Beulich
2013-06-27 17:29 ` David Vrabel
2013-06-28 6:53 ` Jan Beulich
2013-06-24 17:42 ` [PATCH 04/10] kexec: add infrastructure for handling kexec images David Vrabel
2013-06-25 7:54 ` Jan Beulich
2013-06-27 17:17 ` David Vrabel [this message]
2013-06-24 17:42 ` [PATCH 05/10] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-06-25 8:31 ` Jan Beulich
2013-06-25 14:30 ` David Vrabel
2013-06-25 14:59 ` Jan Beulich
2013-06-25 18:52 ` Daniel Kiper
2013-06-27 17:39 ` David Vrabel
2013-06-24 17:42 ` [PATCH 06/10] xen: kexec crash image when dom0 crashes David Vrabel
2013-06-24 17:42 ` [PATCH 07/10] libxc: add hypercall buffer arrays David Vrabel
2013-06-24 17:42 ` [PATCH 08/10] libxc: add API for kexec hypercall David Vrabel
2013-06-24 17:42 ` [PATCH 09/10] x86: check kexec relocation code fits in a page David Vrabel
2013-06-25 8:33 ` Jan Beulich
2013-06-25 9:31 ` Andrew Cooper
2013-06-25 11:38 ` Jan Beulich
2013-06-25 16:38 ` Ian Campbell
2013-06-25 19:00 ` Daniel Kiper
2013-06-26 9:50 ` David Vrabel
2013-06-24 17:42 ` [PATCH 10/10] MAINTAINERS: Add KEXEC maintainer David Vrabel
2013-06-24 20:31 ` [PATCHv6 0/10] kexec: extend kexec hypercall for use with pv-ops kernels Andrew Cooper
2013-06-25 19:27 ` Daniel Kiper
2013-06-26 9:44 ` David Vrabel
2013-06-26 9:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC7398.3040202@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=daniel.kiper@oracle.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).