From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 05/10] kexec: extend hypercall with improved
 load/unload ops
Date: Thu, 27 Jun 2013 18:39:02 +0100
Message-ID: <51CC78B6.3000804@citrix.com>
References: <1372095741-27012-1-git-send-email-david.vrabel@citrix.com>
	<1372095741-27012-6-git-send-email-david.vrabel@citrix.com>
	<20130625185219.GA10322@debian70-amd64.local.net-space.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130625185219.GA10322@debian70-amd64.local.net-space.pl>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: Keir Fraser <keir@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 25/06/13 19:52, Daniel Kiper wrote:
> On Mon, Jun 24, 2013 at 06:42:16PM +0100, David Vrabel wrote:
>> 
>> +        .globl __kexec_reloc_size
>> +        .set __kexec_reloc_size, . - kexec_reloc
>> +        .globl kexec_reloc_size
>> +kexec_reloc_size:
>> +        .quad __kexec_reloc_size
> 
> Why do you define two variables to store the same value?
> 
>   .globl kexec_reloc_size /* Personaly I prefer do this at the beginning of S file. */
> kexec_reloc_size:
>   .long . - xen_relocate_kernel
> 
> It should work for C files and linker script.

This doesn't work, to the linker the value of kexec_reloc_size is its
address.

David