From mboxrd@z Thu Jan 1 00:00:00 1970 From: DuanZhenzhong Subject: Re: [PATCH] qemu-xen: free all the pirqs for msi/msix when driver unload Date: Tue, 02 Jul 2013 13:54:57 +0800 Message-ID: <51D26B31.8010409@oracle.com> References: <51D117A8.80403@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: Anthony.Perard@citrix.com, Feng Jin , xen-devel List-Id: xen-devel@lists.xenproject.org Stefano Stabellini wrote: > On Mon, 1 Jul 2013, Zhenzhong Duan wrote: > >> Pirqs are not freed when driver unload, then new pirqs are allocated when >> driver reload. This could exhaust pirqs if do it in a loop. >> >> This patch fixes the bug by freeing pirqs when ENABLE bit is cleared in >> msi/msix control reg. >> >> There is also other way of fixing it such as reuse pirqs between driver reload, >> but this way is better. >> Xen-devel: http://marc.info/?l=xen-devel&m=136800120304275&w=2 >> >> Signed-off-by: Zhenzhong Duan >> > > It looks OK to me, I'll have to trust you to have tested this patch > properly too. > Not yet, it just passed build test. Pls hold off until I got permit to override the 4.1.30-OVM test env with upstream things and test. Or is there some way of testing with 4.1.30-OVM + qemu-system-i386 ? zduan