From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86: drop MAX_VECTOR definition
Date: Tue, 2 Jul 2013 10:26:50 +0100 [thread overview]
Message-ID: <51D29CDA.3080609@citrix.com> (raw)
In-Reply-To: <51D2984002000078000E21A9@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1508 bytes --]
On 02/07/13 08:07, Jan Beulich wrote:
> .. in favor of NR_VECTORS, as being redundant and as the latter is
> correct in terms of its naming, while the former is off by one.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -90,10 +90,10 @@ static const unsigned int vlapic_lvt_mas
> ((vlapic_get_reg(vlapic, APIC_LVTT) & APIC_TIMER_MODE_MASK) \
> == APIC_TIMER_MODE_TSC_DEADLINE)
>
> -static int vlapic_find_highest_vector(void *bitmap)
> +static int vlapic_find_highest_vector(const void *bitmap)
> {
> - uint32_t *word = bitmap;
> - int word_offset = MAX_VECTOR / 32;
> + const uint32_t *word = bitmap;
> + unsigned int word_offset = NR_VECTORS / 32;
>
> /* Work backwards through the bitmap (first 32-bit word in every four). */
> while ( (word_offset != 0) && (word[(--word_offset)*4] == 0) )
> --- a/xen/include/asm-x86/hvm/vlapic.h
> +++ b/xen/include/asm-x86/hvm/vlapic.h
> @@ -26,8 +26,6 @@
> #include <public/hvm/ioreq.h>
> #include <asm/hvm/vpt.h>
>
> -#define MAX_VECTOR 256
> -
> #define vcpu_vlapic(x) (&(x)->arch.hvm_vcpu.vlapic)
> #define vlapic_vcpu(x) (container_of((x), struct vcpu, arch.hvm_vcpu.vlapic))
> #define vlapic_domain(x) (vlapic_vcpu(x)->domain)
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2402 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2013-07-02 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 7:07 [PATCH] x86: drop MAX_VECTOR definition Jan Beulich
2013-07-02 7:54 ` Keir Fraser
2013-07-02 9:26 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D29CDA.3080609@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).