From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Eddie Dong <eddie.dong@intel.com>,
xen-devel <xen-devel@lists.xen.org>,
paul.durrant@citrix.com, Jun Nakajima <jun.nakajima@intel.com>,
Yang Z Zhang <yang.z.zhang@intel.com>
Subject: Re: [PATCH v2 5/5] Viridian: cleanup
Date: Thu, 4 Jul 2013 10:38:47 +0100 [thread overview]
Message-ID: <51D542A7.6040707@citrix.com> (raw)
In-Reply-To: <51C80C8302000078000DFDDB@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1777 bytes --]
On 24/06/13 08:08, Jan Beulich wrote:
> - functions used only locally should be static
> - constify parameters of dump functions
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/hvm/viridian.c
> +++ b/xen/arch/x86/hvm/viridian.c
> @@ -111,7 +111,7 @@ int cpuid_viridian_leaves(unsigned int l
> return 1;
> }
>
> -void dump_guest_os_id(struct domain *d)
> +static void dump_guest_os_id(const struct domain *d)
> {
> gdprintk(XENLOG_INFO, "GUEST_OS_ID:\n");
> gdprintk(XENLOG_INFO, "\tvendor: %x\n",
> @@ -128,7 +128,7 @@ void dump_guest_os_id(struct domain *d)
> d->arch.hvm_domain.viridian.guest_os_id.fields.build_number);
> }
>
> -void dump_hypercall(struct domain *d)
> +static void dump_hypercall(const struct domain *d)
> {
> gdprintk(XENLOG_INFO, "HYPERCALL:\n");
> gdprintk(XENLOG_INFO, "\tenabled: %x\n",
> @@ -137,7 +137,7 @@ void dump_hypercall(struct domain *d)
> (unsigned long)d->arch.hvm_domain.viridian.hypercall_gpa.fields.pfn);
> }
>
> -void dump_apic_assist(struct vcpu *v)
> +static void dump_apic_assist(const struct vcpu *v)
> {
> gdprintk(XENLOG_INFO, "APIC_ASSIST[%d]:\n", v->vcpu_id);
> gdprintk(XENLOG_INFO, "\tenabled: %x\n",
> @@ -180,7 +180,7 @@ static void enable_hypercall_page(struct
> put_page_and_type(page);
> }
>
> -void initialize_apic_assist(struct vcpu *v)
> +static void initialize_apic_assist(struct vcpu *v)
> {
> struct domain *d = v->domain;
> unsigned long gmfn = v->arch.hvm_vcpu.viridian.apic_assist.fields.pfn;
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2630 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-07-04 9:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 6:54 [PATCH v2 0/5] VMX: fix interaction of Viridian emulation with advanced features Jan Beulich
2013-06-24 7:03 ` [PATCH v2 1/5] VMX: fix interaction of APIC-V and Viridian emulation Jan Beulich
2013-06-24 10:10 ` George Dunlap
2013-06-24 12:52 ` Jan Beulich
2013-06-24 13:09 ` George Dunlap
2013-06-24 13:26 ` Jan Beulich
2013-06-24 13:29 ` George Dunlap
2013-06-24 13:48 ` Jan Beulich
2013-07-04 9:03 ` Andrew Cooper
2013-06-24 7:04 ` [PATCH v2 2/5] VMX/Viridian: suppress MSR-based APIC suggestion when having APIC-V Jan Beulich
2013-06-25 10:29 ` Paul Durrant
2013-06-25 13:43 ` George Dunlap
2013-06-25 13:59 ` Jan Beulich
2013-06-24 7:06 ` [PATCH v2 3/5] VMX: suppress pointless indirect calls Jan Beulich
2013-07-04 9:10 ` Andrew Cooper
2013-06-24 7:06 ` [PATCH v2 4/5] Viridian: populate CPUID leaf 6 Jan Beulich
2013-07-04 9:38 ` Andrew Cooper
2013-07-04 10:05 ` Jan Beulich
2013-07-04 10:18 ` Andrew Cooper
2013-06-24 7:08 ` [PATCH v2 5/5] Viridian: cleanup Jan Beulich
2013-07-04 9:38 ` Andrew Cooper [this message]
2013-07-04 8:38 ` [PATCH v2 0/5] VMX: fix interaction of Viridian emulation with advanced features Jan Beulich
2013-07-04 9:24 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D542A7.6040707@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).