From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Xen-devel] [PATCH] libxl: Spice usbredirection support for upstream qemu Date: Thu, 04 Jul 2013 22:09:26 +0200 Message-ID: <51D5D676.2080901@redhat.com> References: <1372932359-4625-1-git-send-email-fabio.fantoni@m2r.biz> <20130704101203.GS7483@zion.uk.xensource.com> <51D54B8B.9010703@m2r.biz> <20130704103224.GT7483@zion.uk.xensource.com> <51D564CB.9090602@m2r.biz> <51D5AE39.2010606@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <51D5AE39.2010606@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: xen-devel@lists.xensource.com, Wei Liu , Ian.Campbell@citrix.com, Stefano Stabellini , Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org, Hans de Goede , Fabio Fantoni , spice-devel@lists.freedesktop.org List-Id: xen-devel@lists.xenproject.org Il 04/07/2013 19:17, Andreas Färber ha scritto: > Also if at some point you try to use, e.g., q35 rather than i440fx > machine, it might have EHCI by default and the snippet would be > instantiating a duplicate one. I.e., the three levels of dependency > could be separated more clearly: PCI, USB, redirection. At least you could start specifying the USB desired version (1.1, 2.0 with companion controllers, 3.0) as an extension of the "usb=1" that is already supported. Paolo > Stating the obvious, a loop would be a more readable solution for adding > 4 devices only differing in device/chardev id. ;)