[PATCH] [Backport 4.2.x] Fix issue with 'xl list -l' showing domids as -1 when using SXP

[PATCH] [Backport 4.2.x] Fix issue with 'xl list -l' showing domids as -1 when using SXP

[Ian Murray]

During investigation of other issues, it came to light that in at least
4.2.2, "xl list -l" displays domain ids as -1 when using SXP, irrespective
of actual value. Ian C identified that this issue was likely fixed in the
upcoming 4.3 release but the commit responsible for the fix
(a73a7a0c647a9a5e30d8bc473c0a1e8648817183) was not likely a candidate for
backporting in its entirety.

Therefore, this patch is just an isolation of the hunk to fix the above issue.

Original Commit Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Backport Created-by: Ian Murray <murrayie@yahoo.co.uk>
---
 tools/libxl/xl_cmdimpl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 7780426..fe8dc92 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -2809,7 +2809,7 @@ static void list_domains_details(const libxl_dominfo *info, int nb_domain)
         if (default_output_format == OUTPUT_FORMAT_JSON)
             s = printf_info_one_json(hand, info[i].domid, &d_config);
         else
-            printf_info_sexp(domid, &d_config);
+            printf_info_sexp(info[i].domid, &d_config);
         libxl_domain_config_dispose(&d_config);
         free(data);
         free(config_source);
-- 
1.7.9.5

Re: [PATCH] [Backport 4.2.x] Fix issue with 'xl list -l' showing domids as -1 when using SXP

[Andrew Cooper]

On 05/07/13 00:34, Ian Murray wrote:
> During investigation of other issues, it came to light that in at least
> 4.2.2, "xl list -l" displays domain ids as -1 when using SXP, irrespective
> of actual value. Ian C identified that this issue was likely fixed in the
> upcoming 4.3 release but the commit responsible for the fix
> (a73a7a0c647a9a5e30d8bc473c0a1e8648817183) was not likely a candidate for
> backporting in its entirety.
>
> Therefore, this patch is just an isolation of the hunk to fix the above issue.
>
> Original Commit Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Backport Created-by: Ian Murray <murrayie@yahoo.co.uk>

As this is a backport request for the tools component, it needs to be
CC'd to Ian Jackson (done)

~Andrew

> ---
>  tools/libxl/xl_cmdimpl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 7780426..fe8dc92 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -2809,7 +2809,7 @@ static void list_domains_details(const libxl_dominfo *info, int nb_domain)
>          if (default_output_format == OUTPUT_FORMAT_JSON)
>              s = printf_info_one_json(hand, info[i].domid, &d_config);
>          else
> -            printf_info_sexp(domid, &d_config);
> +            printf_info_sexp(info[i].domid, &d_config);
>          libxl_domain_config_dispose(&d_config);
>          free(data);
>          free(config_source);

Re: [PATCH] [Backport 4.2.x] Fix issue with 'xl list -l' showing domids as -1 when using SXP [and 1 more messages]

[Ian Jackson]

Ian Murray writes ("[Xen-devel] [PATCH] [Backport 4.2.x] Fix issue with 'xl list -l' showing domids as -1 when using SXP"):
> During investigation of other issues, it came to light that in at least
> 4.2.2, "xl list -l" displays domain ids as -1 when using SXP, irrespective
> of actual value. Ian C identified that this issue was likely fixed in the
> upcoming 4.3 release but the commit responsible for the fix
> (a73a7a0c647a9a5e30d8bc473c0a1e8648817183) was not likely a candidate for
> backporting in its entirety.
> 
> Therefore, this patch is just an isolation of the hunk to fix the above issue.

Thanks, applied to 4.2.

Ian.