From: Don Slutz <dslutz@verizon.com>
To: Don Slutz <dslutz@verizon.com>
Cc: ian.campbell@citrix.com, alex@alex.org.uk,
Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org,
jbeulich@suse.com, anthony.perard@citrix.com
Subject: Re: [PATCH] libxl_json: Fix backport of JSON_BOOL to 4.2.2
Date: Fri, 5 Jul 2013 11:30:11 -0400 [thread overview]
Message-ID: <51D6E683.9020906@terremark.com> (raw)
In-Reply-To: <1373037105-1574-1-git-send-email-dslutz@verizon.com>
Looks like I had an issue with the mailer I used, and this did not get to anyone at citrix.com. Resending via a different SMTP server.
-Don Slutz
On 07/05/13 11:11, Don Slutz wrote:
> Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of obj->u.b
> Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not.
>
> This shows up by vnc-port and vnc-listen are missing in xenstore when they should not be.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
> tools/libxl/libxl_json.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
> index 72b52e8..0810630 100644
> --- a/tools/libxl/libxl_json.c
> +++ b/tools/libxl/libxl_json.c
> @@ -474,6 +474,7 @@ static int json_callback_boolean(void *opaque, int boolean)
>
> if ((obj = libxl__json_object_alloc(ctx->gc, JSON_BOOL)) == NULL)
> return 0;
> + obj->u.b = boolean;
>
> if (libxl__json_object_append_to(ctx->gc, obj, ctx->current) == -1) {
> libxl__json_object_free(ctx->gc, obj);
next prev parent reply other threads:[~2013-07-05 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 15:11 [PATCH] libxl_json: Fix backport of JSON_BOOL to 4.2.2 Don Slutz
2013-07-05 15:30 ` Don Slutz [this message]
2013-07-05 20:29 ` Konrad Rzeszutek Wilk
2013-07-05 20:40 ` Don Slutz
2013-07-05 21:09 ` Konrad Rzeszutek Wilk
2013-07-08 13:57 ` Don Slutz
2013-07-06 13:19 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D6E683.9020906@terremark.com \
--to=dslutz@verizon.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=alex@alex.org.uk \
--cc=anthony.perard@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).