Re: [PATCH 1/1 V2] x86/AMD: Fix nested svm crash due to assertion in __virt_to_maddr

["Egger, Christoph" <chegger@amazon.de>]

On 08.07.13 11:37, Jan Beulich wrote:
>>>> On 08.07.13 at 11:18, "Egger, Christoph" <chegger@amazon.de> wrote:
>> On 08.07.13 11:13, Jan Beulich wrote:
>>>>>> On 06.07.13 at 00:10, <suravee.suthikulpanit@amd.com> wrote:
>>>> @@ -1816,7 +1816,7 @@ svm_vmexit_do_vmload(struct vmcb_struct *vmcb,
>>>>          goto inject;
>>>>      }
>>>>  
>>>> -    svm_vmload(nv->nv_vvmcx);
>>>> +    svm_vmload_by_paddr(nv->nv_vvmcxaddr);
>>>>      /* State in L1 VMCB is stale now */
>>>>      v->arch.hvm_svm.vmcb_in_sync = 0;
>>>>  
>>>> @@ -1852,7 +1852,7 @@ svm_vmexit_do_vmsave(struct vmcb_struct *vmcb,
>>>>          goto inject;
>>>>      }
>>>>  
>>>> -    svm_vmsave(nv->nv_vvmcx);
>>>> +    svm_vmsave_by_paddr(nv->nv_vvmcxaddr);
>>>>  
>>>>      __update_guest_eip(regs, inst_len);
>>>>      return;
>>>
>>> As said on the previous version already - from all I can tell these
>>> are GPAs, not PAs, and hence can't be passed untranslated to
>>> VMLOAD/VMSAVE. If I'm right with this, I also can't see how this
>>> would have worked for you...
>>
>> You can translate GPA->PA with the hostp2m.
> 
> I don't think I understand what you're trying to tell me with this.

This information is supposed for suravee. Sorry for being unclear.

Christoph