From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH] libxl_json: Fix backport of JSON_BOOL to 4.2.2 Date: Mon, 8 Jul 2013 09:57:32 -0400 Message-ID: <51DAC54C.1060909@terremark.com> References: <1373037105-1574-1-git-send-email-dslutz@verizon.com> <51D6E683.9020906@terremark.com> <365670c2-8ac1-4782-9efd-040f5a3fa163@email.android.com> <51D72F4F.6060904@terremark.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000302070504000205000605" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: jbeulich@suse.com, Ian.Jackson@eu.citrix.com, Don Slutz , xen-devel@lists.xen.org, alex@alex.org.uk, anthony.perard@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org --------------000302070504000205000605 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 07/05/13 17:09, Konrad Rzeszutek Wilk wrote: > Don Slutz wrote: > >> On 07/05/13 16:29, Konrad Rzeszutek Wilk wrote: >>> Don Slutz wrote: >>> >>>> Looks like I had an issue with the mailer I used, and this did not >> get >>>> to anyone at citrix.com. Resending via a different SMTP server. >>>> -Don Slutz >>>> >>>> On 07/05/13 11:11, Don Slutz wrote: >>>>> Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of >>>> obj->u.b >>>>> Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not. >>>>> >>>>> This shows up by vnc-port and vnc-listen are missing in xenstore >> when >>>> they should not be. >>>>> Signed-off-by: Don Slutz >>>>> --- >>>>> tools/libxl/libxl_json.c | 1 + >>>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c >>>>> index 72b52e8..0810630 100644 >>>>> --- a/tools/libxl/libxl_json.c >>>>> +++ b/tools/libxl/libxl_json.c >>>>> @@ -474,6 +474,7 @@ static int json_callback_boolean(void *opaque, >>>> int boolean) >>>>> >>>>> if ((obj = libxl__json_object_alloc(ctx->gc, JSON_BOOL)) == >>>> NULL) >>>>> return 0; >>>>> + obj->u.b = boolean; >>>>> >>>>> if (libxl__json_object_append_to(ctx->gc, obj, ctx->current) >> == >>>> -1) { >>>>> libxl__json_object_free(ctx->gc, obj); >>>> _______________________________________________ >>>> Xen-devel mailing list >>>> Xen-devel@lists.xen.org >>>> http://lists.xen.org/xen-devel >>> Could you also include in the commit description not just the git >> commit id but also also the title of said patches? Thanks >> How does this look: >> >> Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of >> obj->u.b >> libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL. >> >> Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not. >> libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL. >> >> This shows up by vnc-port and vnc-listen are missing in xenstore >> when they should not be. >> >> for the commit message? >> -Don Slutz > I don't have my git tree in front of me but are you sure that both git commits have the same title. That would be pretty odd. > > Anyhow I usually just include the title right after the commit as: git commit xyz ('title of said patch'). I have attached a v2 of the commit message (including the Acked-By: Alex Bligh) and the 2 git commit messages referred to. I can top post the v2 if needed. -Don Slutz --------------000302070504000205000605 Content-Type: text/plain; charset="us-ascii"; name="0001-libxl_json-Fix-backport-of-JSON_BOOL-to-4.2.2.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-libxl_json-Fix-backport-of-JSON_BOOL-to-4.2.2.patch" RnJvbSAyMjg4ODY3MzI3NjNmZDA2ZWNmYWJiMTdkMWEyZjk0N2FiMzAzYTJhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEb24gU2x1dHogPGRzbHV0ekB2ZXJpem9uLmNvbT4K RGF0ZTogRnJpLCA1IEp1bCAyMDEzIDEwOjU4OjQ4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0g bGlieGxfanNvbjogRml4IGJhY2twb3J0IG9mIEpTT05fQk9PTCB0byA0LjIuMgoKZ2l0IGNv bW1pdCAyYjMwNzJlZDBjYmVlZDhjMDM4NWYyMGU5MmJhMGYxMjAxZGI4YTE3ICgnbGlieGxf anNvbjogUmVwbGFjZSBKU09OX1RSVUUvRkFMU0UgYnkgSlNPTl9CT09MLicpCiBoYXMgdGhl IHNldHRpbmcgb2Ygb2JqLT51LmIKCmdpdCBjb21taXQgNmEyYWNhOWZkZWYwNDk5ZTYxMzcx NWJhZjEwN2YyMjk2YjkwMDdjZiAoJ2xpYnhsX2pzb246IFJlcGxhY2UgSlNPTl9UUlVFL0ZB TFNFIGJ5IEpTT05fQk9PTC4nKQogZG9lcyBub3QuCgpUaGlzIHNob3dzIHVwIGJ5IHZuYy1w b3J0IGFuZCB2bmMtbGlzdGVuIGFyZSBtaXNzaW5nIGluIHhlbnN0b3JlIHdoZW4gdGhleSBz aG91bGQgbm90IGJlLgoKU2lnbmVkLW9mZi1ieTogRG9uIFNsdXR6IDxkc2x1dHpAdmVyaXpv bi5jb20+CkFja2VkLUJ5OiBBbGV4IEJsaWdoIDxhbGV4QGFsZXgub3JnLnVrPgotLS0KCnYx IC0+IHYyCiBBZGp1c3QgY29tbWl0IG1lc3NhZ2UgYXMgS29ucmFkIFJ6ZXN6dXRlayBXaWxr IHN1Z2VzdGVkLgogQWRkIEFsZXggQmxpZ2gncyBBY2tlZC1CeQoKIHRvb2xzL2xpYnhsL2xp YnhsX2pzb24uYyB8ICAgIDEgKwogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyks IDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxfanNvbi5j IGIvdG9vbHMvbGlieGwvbGlieGxfanNvbi5jCmluZGV4IDcyYjUyZTguLjA4MTA2MzAgMTAw NjQ0Ci0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2pzb24uYworKysgYi90b29scy9saWJ4bC9s aWJ4bF9qc29uLmMKQEAgLTQ3NCw2ICs0NzQsNyBAQCBzdGF0aWMgaW50IGpzb25fY2FsbGJh Y2tfYm9vbGVhbih2b2lkICpvcGFxdWUsIGludCBib29sZWFuKQogCiAgICAgaWYgKChvYmog PSBsaWJ4bF9fanNvbl9vYmplY3RfYWxsb2MoY3R4LT5nYywgSlNPTl9CT09MKSkgPT0gTlVM TCkKICAgICAgICAgcmV0dXJuIDA7CisgICAgb2JqLT51LmIgPSBib29sZWFuOwogCiAgICAg aWYgKGxpYnhsX19qc29uX29iamVjdF9hcHBlbmRfdG8oY3R4LT5nYywgb2JqLCBjdHgtPmN1 cnJlbnQpID09IC0xKSB7CiAgICAgICAgIGxpYnhsX19qc29uX29iamVjdF9mcmVlKGN0eC0+ Z2MsIG9iaik7Ci0tIAoxLjcuMQoK --------------000302070504000205000605 Content-Type: text/plain; charset="us-ascii"; name="commit-2b3072ed0cbeed8c0385f20e92ba0f1201db8a17.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="commit-2b3072ed0cbeed8c0385f20e92ba0f1201db8a17.txt" Y29tbWl0IDJiMzA3MmVkMGNiZWVkOGMwMzg1ZjIwZTkyYmEwZjEyMDFkYjhhMTcKQXV0aG9y OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KRGF0ZTogICBN b24gT2N0IDggMTE6NDU6MzEgMjAxMiArMDEwMAoKICAgIGxpYnhsX2pzb246IFJlcGxhY2Ug SlNPTl9UUlVFL0ZBTFNFIGJ5IEpTT05fQk9PTC4KICAgIAogICAgVGhvc2UgdHdvIEpTT05f VFJVRSBhbmQgSlNPTl9GQUxTRSB3ZXJlIHR5cGVzIG9mIG5vZGUuIEJ1dCBpdCdzIGJldHRl cgogICAgdG8gaGF2ZSBhIHVuaXF1ZSBKU09OX0JPT0wgdHlwZS4KICAgIAogICAgU2lnbmVk LW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+CiAg ICBBY2tlZC1ieTogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KICAg IENvbW1pdHRlZC1ieTogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4K Cg== --------------000302070504000205000605 Content-Type: text/plain; charset="us-ascii"; name="commit-6a2aca9fdef0499e613715baf107f2296b9007cf.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="commit-6a2aca9fdef0499e613715baf107f2296b9007cf.txt" Y29tbWl0IDZhMmFjYTlmZGVmMDQ5OWU2MTM3MTViYWYxMDdmMjI5NmI5MDA3Y2YKQXV0aG9y OiBBbGV4IEJsaWdoIDxhbGV4QGFsZXgub3JnLnVrPgpEYXRlOiAgIFR1ZSBGZWIgMTkgMTU6 MjU6MTMgMjAxMyArMDAwMAoKICAgIGxpYnhsX2pzb246IFJlcGxhY2UgSlNPTl9UUlVFL0ZB TFNFIGJ5IEpTT05fQk9PTC4KICAgIAogICAgVGhvc2UgdHdvIEpTT05fVFJVRSBhbmQgSlNP Tl9GQUxTRSB3ZXJlIHR5cGVzIG9mIG5vZGUuIEJ1dCBpdCdzIGJldHRlcgogICAgdG8gaGF2 ZSBhIHVuaXF1ZSBKU09OX0JPT0wgdHlwZS4KICAgIAogICAgQmFja3BvcnRlZCBmcm9tIHhl bi11bnN0YWJsZSBwYXRjaDoKICAgIDogSEcgY2hhbmdlc2V0IHBhdGNoCiAgICA6IFVzZXIg QW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+CiAgICA6IERhdGUg MTM0OTY5MzEzMSAtMzYwMAogICAgOiBOb2RlIElEIDNmNzFhYWIwZTI3NzRkZWQwYzVhMDM0 MzZjMzY0ZmIwMzFiYTlhYTAKICAgIDogUGFyZW50ICA0YTZkNWQ4Y2JhNGZjNDRmOWJiZGEy MDExODg4ODU4Njg2MDRiOGU4CiAgICBBY2tlZC1ieTogSWFuIEphY2tzb24gPGlhbi5qYWNr c29uQGV1LmNpdHJpeC5jb20+CiAgICBDb21taXR0ZWQtYnk6IElhbiBKYWNrc29uIDxJYW4u SmFja3NvbkBldS5jaXRyaXguY29tPgo= --------------000302070504000205000605 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --------------000302070504000205000605--