From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC Patch v2 13/16] xc_domain_save: flush cache
 before calling callbacks->postcopy()
Date: Thu, 11 Jul 2013 14:43:53 +0100
Message-ID: <51DEB699.2060909@citrix.com>
References: <1373531748-12547-1-git-send-email-wency@cn.fujitsu.com>
	<1373531748-12547-14-git-send-email-wency@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1373531748-12547-14-git-send-email-wency@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, Ye Wei <wei.ye1987@gmail.com>, xen-devl <xen-devel@lists.xen.org>, Hong Tao <bobby.hong@huawei.com>, Xu Yao <xuyao.xu@huawei.com>, Shriram Rajagopalan <rshriram@cs.ubc.ca>
List-Id: xen-devel@lists.xenproject.org

On 11/07/13 09:35, Wen Congyang wrote:
> callbacks->postcopy() may use the fd to transfer something to the
> other end, so we should flush cache before calling callbacks->postcopy()
>
> Signed-off-by: Ye Wei <wei.ye1987@gmail.com>
> Signed-off-by: Jiang Yunhong <yunhong.jiang@intel.com>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---

This looks like it is a bugfix on its own, so perhaps might be better
submitted as individual fix, rather than being mixed in with a huge
series for new functionaltiy

~Andrew

>  tools/libxc/xc_domain_save.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c
> index fbc15e9..b477188 100644
> --- a/tools/libxc/xc_domain_save.c
> +++ b/tools/libxc/xc_domain_save.c
> @@ -2034,9 +2034,6 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, uint32_t max_iter
>   out:
>      completed = 1;
>  
> -    if ( !rc && callbacks->postcopy )
> -        callbacks->postcopy(callbacks->data);
> -
>      /* guest has been resumed. Now we can compress data
>       * at our own pace.
>       */
> @@ -2066,6 +2063,9 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, uint32_t max_iter
>  
>      discard_file_cache(xch, io_fd, 1 /* flush */);
>  
> +    if ( !rc && callbacks->postcopy )
> +        callbacks->postcopy(callbacks->data);
> +
>      /* Enable compression now, finally */
>      compressing = (flags & XCFLAGS_CHECKPOINT_COMPRESS);
>