From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [Xen-devel] [PATCH 2/7] elf: Increase buf size in get_pt_note_info() Date: Fri, 12 Jul 2013 15:04:41 +0100 Message-ID: <51E00CF9.7080604@citrix.com> References: <1373636895-31682-1-git-send-email-daniel.kiper@oracle.com> <1373636895-31682-3-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1373636895-31682-3-git-send-email-daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Kiper Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, kumagai-atsushi-biTfD1RFvDe45+QrQBaojngSJqDPrsil@public.gmane.org List-Id: xen-devel@lists.xenproject.org On 12/07/13 14:48, Daniel Kiper wrote: > get_pt_note_info() always ignores VMCOREINFO_XEN note > because buf size is too small. It does not have place > for \0 char which marks EOS. This patch fixes that bug > and VMCOREINFO_XEN note living in /proc/vmcore file > could be properly detected now. > > Signed-off-by: Daniel Kiper > --- > elf_info.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/elf_info.c b/elf_info.c > index 0c1e36a..70a6dd2 100644 > --- a/elf_info.c > +++ b/elf_info.c > @@ -310,7 +310,7 @@ get_pt_note_info(void) > { > int n_type, size_name, size_desc; > off_t offset, offset_desc; > - char buf[VMCOREINFO_XEN_NOTE_NAME_BYTES]; > + char buf[VMCOREINFO_XEN_NOTE_NAME_BYTES + 1]; > char note[MAX_SIZE_NHDR]; > > nr_cpus = 0; Elf Note namesz is defined to include the terminating null character, so I would argue that VMCOREINFO_XEN_NOTE_NAME_BYTES is off-by-one. ~Andrew