Re: [PATCH 4/6] libxc: allow for ctxt to be NULL in xc_vcpu_setcontext

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 12/07/13 17:48, Dario Faggioli wrote:
> Since, as can be seen in xen/common/domctl.c, that is legitimate.
> Actually, it is the only way to have vcpu_reset() invoked from
> outside Xen.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: George Dunlap <George.Dunlap@eu.citrix.com>
> Cc: Jan Beulich <JBeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>

"it is the only way to have vcpu_reset() invoked from
outside Xen."  without manually constructing a vcpu_op.

Still,

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  tools/libxc/xc_domain.c |    6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> index d64d0bc..a247426 100644
> --- a/tools/libxc/xc_domain.c
> +++ b/tools/libxc/xc_domain.c
> @@ -1140,12 +1140,6 @@ int xc_vcpu_setcontext(xc_interface *xch,
>      DECLARE_HYPERCALL_BOUNCE(ctxt, sizeof(vcpu_guest_context_any_t), XC_HYPERCALL_BUFFER_BOUNCE_IN);
>      int rc;
>  
> -    if (ctxt == NULL)
> -    {
> -        errno = EINVAL;
> -        return -1;
> -    }
> -
>      if ( xc_hypercall_bounce_pre(xch, ctxt) )
>          return -1;
>  
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel