xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
	xiantao.zhang@intel.com, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH resend 3/3] pciif: add multi-vector-MSI command
Date: Tue, 16 Jul 2013 12:19:30 +0100	[thread overview]
Message-ID: <51E52C42.1000808@citrix.com> (raw)
In-Reply-To: <51E5395002000078000E54B2@nat28.tlf.novell.com>


[-- Attachment #1.1: Type: text/plain, Size: 1074 bytes --]

On 16/07/13 11:15, Jan Beulich wrote:
> The requested vector count is to be passed in struct xen_pci_op's info
> field. Upon failure, if a smaller vector count might work, the backend
> will pass that smaller count in the value field (which so far is always
> being set to zero in the error path).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/include/public/io/pciif.h
> +++ b/xen/include/public/io/pciif.h
> @@ -46,6 +46,7 @@
>  #define XEN_PCI_OP_aer_resume		(7)
>  #define XEN_PCI_OP_aer_mmio		(8)
>  #define XEN_PCI_OP_aer_slotreset	(9)
> +#define XEN_PCI_OP_enable_multi_msi	(10)

/* Be sure to bump this number if you change this file */
#define XEN_PCI_MAGIC "7"

Should you bump this version, or is the comment stale?  The only in-tree
consumer I can find is MiniOS's pcifront, which writes it into xenstore.

~Andrew

>  
>  /* xen_pci_op error numbers */
>  #define XEN_PCI_ERR_success          (0)
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel


[-- Attachment #1.2: Type: text/html, Size: 1934 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-07-16 11:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 10:00 [PATCH resend 0/3] x86/IOMMU: multi-vector MSI Jan Beulich
2013-07-16 10:13 ` [PATCH resend 1/3] VT-d: enable for " Jan Beulich
2013-07-16 11:15   ` Andrew Cooper
2013-07-16 11:32     ` Jan Beulich
2013-07-17  9:50       ` Andrew Cooper
2013-07-18 10:48         ` Zhang, Xiantao
2013-07-16 10:14 ` [PATCH resend 2/3] x86: enable " Jan Beulich
2013-07-16 11:36   ` Andrew Cooper
2013-07-16 11:48     ` Jan Beulich
2013-07-17 10:02       ` Andrew Cooper
2013-08-05 13:11   ` Ping: " Jan Beulich
2013-08-08  9:02   ` Keir Fraser
2013-07-16 10:15 ` [PATCH resend 3/3] pciif: add multi-vector-MSI command Jan Beulich
2013-07-16 11:19   ` Andrew Cooper [this message]
2013-07-16 11:35     ` Jan Beulich
2013-07-17  9:02       ` Andrew Cooper
2013-08-05 13:12   ` Ping: " Jan Beulich
2013-08-08  9:02   ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E52C42.1000808@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).