From: George Dunlap <george.dunlap@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: RFC: removing hardcoded "modprobe blktap" in xencommons
Date: Thu, 18 Jul 2013 09:43:17 +0100 [thread overview]
Message-ID: <51E7AAA5.7090803@eu.citrix.com> (raw)
In-Reply-To: <20130718073127.GA26530@zion.uk.xensource.com>
On 07/18/2013 08:31 AM, Wei Liu wrote:
> On Wed, Jul 17, 2013 at 12:16:01PM +0100, Ian Jackson wrote:
>> George Dunlap writes ("Re: RFC: removing hardcoded "modprobe blktap" in xencommons"):
>>> If we did something like this, we'd still have to have the modprobes in
>>> xencommons for older kernels; we'd just have to have a way to disable it
>>> for newer kernels.
>>
>> Many of the modules we'd be asking for (eg blktap*) don't exist on
>> newer kernels at all, so the modprobe is harmless.
>>
>> For the others we can check uname.
>>
>
> I think Jan's main point is "defer loading modules till the last
> minute". Checking for uname in xencommons cannot achieve that.
It can defer modules *for systems that can load them automatically*,
while loading them immediately for those that don't. I think that's an
improvement.
-George
next prev parent reply other threads:[~2013-07-18 8:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 16:12 RFC: removing hardcoded "modprobe blktap" in xencommons Wei Liu
2013-07-12 18:00 ` Konrad Rzeszutek Wilk
2013-07-13 17:05 ` Wei Liu
2013-07-15 6:13 ` Jan Beulich
2013-07-15 6:06 ` Jan Beulich
2013-07-15 7:33 ` Wei Liu
2013-07-15 7:44 ` Jan Beulich
2013-07-15 8:26 ` Wei Liu
2013-07-15 9:34 ` Jan Beulich
2013-07-15 9:38 ` Wei Liu
2013-07-15 14:08 ` George Dunlap
2013-07-15 14:13 ` Jan Beulich
2013-07-17 11:16 ` Ian Jackson
2013-07-18 7:31 ` Wei Liu
2013-07-18 8:43 ` George Dunlap [this message]
2013-07-18 11:12 ` Ian Jackson
2013-08-01 13:27 ` Wei Liu
2013-08-07 15:16 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E7AAA5.7090803@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).