From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v2 1/2] xen/balloon: set a mapping for
	ballooned out pages
Date: Mon, 22 Jul 2013 18:26:46 +0100
Message-ID: <51ED6B56.6060807@citrix.com>
References: <alpine.DEB.2.02.1307221717160.4893@kaball.uk.xensource.com>	
	<1374510529-10395-1-git-send-email-stefano.stabellini@eu.citrix.com>	
	<51ED6317.2060707@citrix.com>
	<1374513727.6623.17.camel@hastur.hellion.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1374513727.6623.17.camel@hastur.hellion.org.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: dcrisan@flexiant.com, xen-devel@lists.xensource.com, alex@alex.org.uk, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 22/07/13 18:22, Ian Campbell wrote:
> On Mon, 2013-07-22 at 17:51 +0100, David Vrabel wrote:
>> On 22/07/13 17:28, Stefano Stabellini wrote:
>>>
>>>  #ifdef CONFIG_HIGHMEM
>>>  #define inc_totalhigh_pages() (totalhigh_pages++)
>>> @@ -423,7 +426,8 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
>>>  		if (xen_pv_domain() && !PageHighMem(page)) {
>>>  			ret = HYPERVISOR_update_va_mapping(
>>>  				(unsigned long)__va(pfn << PAGE_SHIFT),
>>> -				__pte_ma(0), 0);
>>> +				pfn_pte(page_to_pfn(get_balloon_trade_page()),
>>> +					PAGE_KERNEL_RO), 0);
>>
>> Preemption needs to be disabled while using the trade page, see
>> suggestion below.
> 
> Hopefully you mean just when setting up/manipulating it?

Yes, sorry.

get_...()
update_va_mapping()
put_...()

David