From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: arm: panic if we cannot build dom0's p2m.
Date: Tue, 23 Jul 2013 18:12:32 +0100 [thread overview]
Message-ID: <51EEB980.1010808@linaro.org> (raw)
In-Reply-To: <1374599184-3902-1-git-send-email-ijc@hellion.org.uk>
On 07/23/2013 06:06 PM, Ian Campbell wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/domain_build.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 155b436..056c9df 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -121,7 +121,8 @@ static int set_memory_reg(struct domain *d, struct kernel_info *kinfo,
> device_tree_set_reg(&new_cell, address_cells, size_cells, start, size);
>
> printk("Populate P2M %#"PRIx64"->%#"PRIx64"\n", start, start + size);
> - p2m_populate_ram(d, start, start + size);
> + if ( p2m_populate_ram(d, start, start + size) < 0 )
> + panic("Failed to populate P2M\n");
> kinfo->mem.bank[kinfo->mem.nr_banks].start = start;
> kinfo->mem.bank[kinfo->mem.nr_banks].size = size;
> kinfo->mem.nr_banks++;
>
next prev parent reply other threads:[~2013-07-23 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 17:06 [PATCH] xen: arm: panic if we cannot build dom0's p2m Ian Campbell
2013-07-23 17:12 ` Julien Grall [this message]
2013-07-29 15:58 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EEB980.1010808@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ijc@hellion.org.uk \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).