xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen: arm: panic if we cannot build dom0's p2m.
@ 2013-07-23 17:06 Ian Campbell
  2013-07-23 17:12 ` Julien Grall
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2013-07-23 17:06 UTC (permalink / raw)
  To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini

From: Ian Campbell <ian.campbell@citrix.com>

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 xen/arch/arm/domain_build.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 155b436..056c9df 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -121,7 +121,8 @@ static int set_memory_reg(struct domain *d, struct kernel_info *kinfo,
         device_tree_set_reg(&new_cell, address_cells, size_cells, start, size);
 
         printk("Populate P2M %#"PRIx64"->%#"PRIx64"\n", start, start + size);
-        p2m_populate_ram(d, start, start + size);
+        if ( p2m_populate_ram(d, start, start + size) < 0 )
+            panic("Failed to populate P2M\n");
         kinfo->mem.bank[kinfo->mem.nr_banks].start = start;
         kinfo->mem.bank[kinfo->mem.nr_banks].size = size;
         kinfo->mem.nr_banks++;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen: arm: panic if we cannot build dom0's p2m.
  2013-07-23 17:06 [PATCH] xen: arm: panic if we cannot build dom0's p2m Ian Campbell
@ 2013-07-23 17:12 ` Julien Grall
  2013-07-29 15:58   ` Ian Campbell
  0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2013-07-23 17:12 UTC (permalink / raw)
  To: Ian Campbell; +Cc: stefano.stabellini, tim, Ian Campbell, xen-devel

On 07/23/2013 06:06 PM, Ian Campbell wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
>  xen/arch/arm/domain_build.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 155b436..056c9df 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -121,7 +121,8 @@ static int set_memory_reg(struct domain *d, struct kernel_info *kinfo,
>          device_tree_set_reg(&new_cell, address_cells, size_cells, start, size);
>  
>          printk("Populate P2M %#"PRIx64"->%#"PRIx64"\n", start, start + size);
> -        p2m_populate_ram(d, start, start + size);
> +        if ( p2m_populate_ram(d, start, start + size) < 0 )
> +            panic("Failed to populate P2M\n");
>          kinfo->mem.bank[kinfo->mem.nr_banks].start = start;
>          kinfo->mem.bank[kinfo->mem.nr_banks].size = size;
>          kinfo->mem.nr_banks++;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen: arm: panic if we cannot build dom0's p2m.
  2013-07-23 17:12 ` Julien Grall
@ 2013-07-29 15:58   ` Ian Campbell
  0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2013-07-29 15:58 UTC (permalink / raw)
  To: Julien Grall; +Cc: xen-devel, tim, stefano.stabellini

On Tue, 2013-07-23 at 18:12 +0100, Julien Grall wrote:
> On 07/23/2013 06:06 PM, Ian Campbell wrote:
> > From: Ian Campbell <ian.campbell@citrix.com>
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Acked-by: Julien Grall <julien.grall@linaro.org>

Thanks, applied.

> > ---
> >  xen/arch/arm/domain_build.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index 155b436..056c9df 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -121,7 +121,8 @@ static int set_memory_reg(struct domain *d, struct kernel_info *kinfo,
> >          device_tree_set_reg(&new_cell, address_cells, size_cells, start, size);
> >  
> >          printk("Populate P2M %#"PRIx64"->%#"PRIx64"\n", start, start + size);
> > -        p2m_populate_ram(d, start, start + size);
> > +        if ( p2m_populate_ram(d, start, start + size) < 0 )
> > +            panic("Failed to populate P2M\n");
> >          kinfo->mem.bank[kinfo->mem.nr_banks].start = start;
> >          kinfo->mem.bank[kinfo->mem.nr_banks].size = size;
> >          kinfo->mem.nr_banks++;
> > 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-29 15:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-23 17:06 [PATCH] xen: arm: panic if we cannot build dom0's p2m Ian Campbell
2013-07-23 17:12 ` Julien Grall
2013-07-29 15:58   ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).