From: Julien Grall <julien.grall@linaro.org>
To: Julien Grall <julien.grall@linaro.org>
Cc: Stefano.Stabellini@eu.citrix.com, ian.campbell@citrix.com,
patches@linaro.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: Clean up identify processor call for secondary cpus
Date: Thu, 25 Jul 2013 16:36:30 +0100 [thread overview]
Message-ID: <51F145FE.7070004@linaro.org> (raw)
In-Reply-To: <1374766150-534-1-git-send-email-julien.grall@linaro.org>
On 07/25/2013 04:29 PM, Julien Grall wrote:
> The smp_processor_id() is set at the beginning of start_secondary. We don't
> need to compute ourself the offset of the cpu data.
I forgot the signed-off-by.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/smpboot.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index 5895178..872cc25 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -137,15 +137,12 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
> unsigned long fdt_paddr,
> unsigned long cpuid)
> {
> - struct cpuinfo_arm *c = cpu_data + cpuid;
> -
> memset(get_cpu_info(), 0, sizeof (struct cpu_info));
>
> /* TODO: handle boards where CPUIDs are not contiguous */
> set_processor_id(cpuid);
>
> - *c = boot_cpu_data;
> - identify_cpu(c);
> + identify_cpu(¤t_cpu_data);
>
> init_traps();
>
>
next prev parent reply other threads:[~2013-07-25 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 15:29 [PATCH] xen/arm: Clean up identify processor call for secondary cpus Julien Grall
2013-07-25 15:36 ` Julien Grall [this message]
2013-07-29 8:57 ` Ian Campbell
2013-07-29 11:05 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F145FE.7070004@linaro.org \
--to=julien.grall@linaro.org \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).