From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Clean up identify processor call for secondary cpus Date: Thu, 25 Jul 2013 16:36:30 +0100 Message-ID: <51F145FE.7070004@linaro.org> References: <1374766150-534-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374766150-534-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Stefano.Stabellini@eu.citrix.com, ian.campbell@citrix.com, patches@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/25/2013 04:29 PM, Julien Grall wrote: > The smp_processor_id() is set at the beginning of start_secondary. We don't > need to compute ourself the offset of the cpu data. I forgot the signed-off-by. Signed-off-by: Julien Grall > --- > xen/arch/arm/smpboot.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > index 5895178..872cc25 100644 > --- a/xen/arch/arm/smpboot.c > +++ b/xen/arch/arm/smpboot.c > @@ -137,15 +137,12 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset, > unsigned long fdt_paddr, > unsigned long cpuid) > { > - struct cpuinfo_arm *c = cpu_data + cpuid; > - > memset(get_cpu_info(), 0, sizeof (struct cpu_info)); > > /* TODO: handle boards where CPUIDs are not contiguous */ > set_processor_id(cpuid); > > - *c = boot_cpu_data; > - identify_cpu(c); > + identify_cpu(¤t_cpu_data); > > init_traps(); > >