From: "Egger, Christoph" <chegger@amazon.de>
To: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
Cc: Tim Deegan <tim@xen.org>, JBeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/1 V4] x86/AMD: Fix nested svm crash due to assertion in __virt_to_maddr
Date: Tue, 30 Jul 2013 10:05:39 +0200 [thread overview]
Message-ID: <51F773D3.2080705@amazon.de> (raw)
In-Reply-To: <51F6980C.2060201@amd.com>
On 29.07.13 18:27, Suravee Suthikulanit wrote:
> On 7/29/2013 5:43 AM, Tim Deegan wrote:
>> Hi,
>>
>> At 16:46 -0500 on 26 Jul (1374857167), suravee.suthikulpanit@amd.com
>> wrote:
>>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>>
>>> Fix assertion in __virt_to_maddr when starting nested SVM guest
>>> in debug mode. Investigation has shown that svm_vmsave/svm_vmload
>>> make use of __pa() with invalid address.
>>>
>>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>> This looks much better, but I have a few comments still:
Indeed.
>>
>>> +static struct page_info *
>>> +_get_vmcb_page(struct domain *d, uint64_t vmcbaddr)
>> Can you give this a name that makes it clearer that it's for nested
>> VMCBs and not part of the handling of 'real' VMCBs? Also, please drop
>> the leading underscore.
> What about "get_nvmcb_page"?
>
That's good. If you want to follow the naming scheme I suggest
nsvm_get_nvmcb_page().
Christoph
next prev parent reply other threads:[~2013-07-30 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 21:46 [PATCH 1/1 V4] x86/AMD: Fix nested svm crash due to assertion in __virt_to_maddr suravee.suthikulpanit
2013-07-29 10:43 ` Tim Deegan
2013-07-29 16:27 ` Suravee Suthikulanit
2013-07-29 20:04 ` Tim Deegan
2013-07-30 8:13 ` Egger, Christoph
2013-07-31 15:52 ` Suravee Suthikulanit
2013-07-30 8:05 ` Egger, Christoph [this message]
2013-07-31 8:46 ` Suravee Suthikulanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F773D3.2080705@amazon.de \
--to=chegger@amazon.de \
--cc=JBeulich@suse.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).