From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Egger, Christoph" Subject: Re: [PATCH 1/1 V4] x86/AMD: Fix nested svm crash due to assertion in __virt_to_maddr Date: Tue, 30 Jul 2013 10:05:39 +0200 Message-ID: <51F773D3.2080705@amazon.de> References: <1374875167-2834-1-git-send-email-suravee.suthikulpanit@amd.com> <20130729104334.GA37169@ocelot.phlegethon.org> <51F6980C.2060201@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51F6980C.2060201@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Suravee Suthikulanit Cc: Tim Deegan , JBeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 29.07.13 18:27, Suravee Suthikulanit wrote: > On 7/29/2013 5:43 AM, Tim Deegan wrote: >> Hi, >> >> At 16:46 -0500 on 26 Jul (1374857167), suravee.suthikulpanit@amd.com >> wrote: >>> From: Suravee Suthikulpanit >>> >>> Fix assertion in __virt_to_maddr when starting nested SVM guest >>> in debug mode. Investigation has shown that svm_vmsave/svm_vmload >>> make use of __pa() with invalid address. >>> >>> Signed-off-by: Suravee Suthikulpanit >> This looks much better, but I have a few comments still: Indeed. >> >>> +static struct page_info * >>> +_get_vmcb_page(struct domain *d, uint64_t vmcbaddr) >> Can you give this a name that makes it clearer that it's for nested >> VMCBs and not part of the handling of 'real' VMCBs? Also, please drop >> the leading underscore. > What about "get_nvmcb_page"? > That's good. If you want to follow the naming scheme I suggest nsvm_get_nvmcb_page(). Christoph