From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 0/8] Emulate virtual UART for DOM0 and some UART clean up Date: Thu, 01 Aug 2013 13:20:17 +0100 Message-ID: <51FA5281.80300@linaro.org> References: <1375285109-3053-1-git-send-email-julien.grall@linaro.org> <20130801112819.GF78039@ocelot.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130801112819.GF78039@ocelot.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: patches@linaro.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 08/01/2013 12:28 PM, Tim Deegan wrote: Hi, > At 16:38 +0100 on 31 Jul (1375288700), Julien Grall wrote: >> pl011: Use ioreadl/iowritel > > I seem to be missing this one for some reason. Strange. I resent this patch with you in cc. >> pl011: Move registers' definition in a separate file > > Missing s-o-b, but otherwise Reviewed-by: Tim Deegan > >> xen/arm: Use define instead of hardcoded value in debug-pl011 > > Reviewed-by: Tim Deegan > >> xen/arm: New callback in uart_driver to retrieve serial information >> xen/arm: Implement a virtual UART > > I sent some comments on these two separately. > >> exynos4210: rename UTRSTAT_TX_EMPTY in UTRSTAT_TXFE >> exynos4210: Implement vuart_info callback >> pl011: Implement vuart_info callback > > All 3, Reviewed-by: Tim Deegan Thanks for the review. Cheers, -- Julien