xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: dcrisan@flexiant.com, xen-devel@lists.xensource.com,
	Ian Campbell <Ian.Campbell@citrix.com>,
	alex@alex.org.uk
Subject: Re: [PATCH v4 0/2] make ballooned out pages have a valid mapping at all times
Date: Mon, 5 Aug 2013 15:53:09 +0100	[thread overview]
Message-ID: <51FFBC55.2090908@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1308041531220.4893@kaball.uk.xensource.com>

On 04/08/13 15:38, Stefano Stabellini wrote:
> Hi all,
> this patch series limits problems caused by tcp retransmits on NFS when
> the original block pages were mapped from a foreign domain and now the
> mapping is gone.
> 
> It accomplishes the goal by:
> 
> 1) mapping all ballooned out pages to a per-cpu "balloon_scratch_page";
> 2) making sure that once a grant is unmapped, the original mapping to
> the per-cpu balloon_scratch_page is restored atomically.
> 
> The first patch accomplishes (1), the second patch uses
> GNTTABOP_unmap_and_replace to atomically unmap a grant and restore the
> original mapping.
> 
> 
> 
> Changes in this version:
> - add an early_initcall to clear all the possible per_cpu
>   balloon_scratch_page.

I know Konrad asked for this but I don't think it is necessary.  Many
other users of DEFINE_PER_CPU() assume the space is initialized to zero.

e.g., cpufreq_show_table in drivers/cpufreq/freq_table.c

If this is the only change in v4 I would suggest taking the v3 patches
instead.

David

      parent reply	other threads:[~2013-08-05 14:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-04 14:38 [PATCH v4 0/2] make ballooned out pages have a valid mapping at all times Stefano Stabellini
2013-08-04 14:39 ` [PATCH v4 1/2] xen/balloon: set a mapping for ballooned out pages Stefano Stabellini
2013-08-04 14:39 ` [PATCH v4 2/2] xen/m2p: use GNTTABOP_unmap_and_replace to reinstate the original mapping Stefano Stabellini
2013-08-09 15:26   ` Konrad Rzeszutek Wilk
2013-08-13 11:17     ` Stefano Stabellini
2013-08-13 13:11       ` Konrad Rzeszutek Wilk
2013-08-13 15:38         ` Stefano Stabellini
2013-08-05 14:53 ` David Vrabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FFBC55.2090908@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=alex@alex.org.uk \
    --cc=dcrisan@flexiant.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).