From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: Ping: [PATCH] VT-d: protect against bogus
 information coming from BIOS
Date: Mon, 5 Aug 2013 15:55:10 +0100
Message-ID: <51FFBCCE.2010607@citrix.com>
References: <51DD52EF02000078000E3CDE@nat28.tlf.novell.com>
	<51FFBF8B02000078000E94AC@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51FFBF8B02000078000E94AC@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Ben Guthro <ben@guthro.net>, xiantao.zhang@intel.com, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/08/13 14:06, Jan Beulich wrote:
> Ping?
>
>>>> On 10.07.13 at 12:26, "Jan Beulich" <JBeulich@suse.com> wrote:
>> Add checks similar to those done by Linux: The DRHD address must not
>> be all zeros or all ones (Linux only checks for zero), and capabilities
>> as well as extended capabilities must not be all ones.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>>
>> --- a/xen/drivers/passthrough/vtd/dmar.c
>> +++ b/xen/drivers/passthrough/vtd/dmar.c
>> @@ -447,6 +447,9 @@ acpi_parse_one_drhd(struct acpi_dmar_hea
>>      if ( (ret = acpi_dmar_check_length(header, sizeof(*drhd))) != 0 )
>>          return ret;
>>  
>> +    if ( !drhd->address || !(drhd->address + 1) )
>> +        return -ENODEV;
>> +
>>      dmaru = xzalloc(struct acpi_drhd_unit);
>>      if ( !dmaru )
>>          return -ENOMEM;
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -1159,6 +1159,9 @@ int __init iommu_alloc(struct acpi_drhd_
>>          dprintk(VTDPREFIX,
>>                  "cap = %"PRIx64" ecap = %"PRIx64"\n", iommu->cap, iommu->ecap);
>>      }
>> +    if ( !(iommu->cap + 1) || !(iommu->ecap + 1) )
>> +        return -ENODEV;
>> +
>>      if ( cap_fault_reg_offset(iommu->cap) +
>>           cap_num_fault_regs(iommu->cap) * PRIMARY_FAULT_REG_LEN >= PAGE_SIZE 
>> ||
>>           ecap_iotlb_offset(iommu->ecap) >= PAGE_SIZE )
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel