From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/2] VMX: correct feature checks for MPX and XSAVES Date: Mon, 5 Sep 2016 16:11:55 +0100 Message-ID: <51a891b1-dad6-bab4-9c1c-03dfda6074be@citrix.com> References: <57C96DBF020000780010B2E8@prv-mh.provo.novell.com> <57C96EC6020000780010B305@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7861923547129274712==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgvZ5-0005Ib-6e for xen-devel@lists.xenproject.org; Mon, 05 Sep 2016 15:12:03 +0000 In-Reply-To: <57C96EC6020000780010B305@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , xen-devel Cc: Kevin Tian , Jun Nakajima List-Id: xen-devel@lists.xenproject.org --===============7861923547129274712== Content-Type: multipart/alternative; boundary="------------821F4887DC60C46DC6534758" --------------821F4887DC60C46DC6534758 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit On 02/09/16 11:21, Jan Beulich wrote: > Their VMCS fields aren't tied to the respective base CPU feature flags > but instead to VMX specific ones. > > Note that while the VMCS GUEST_BNDCFGS field exists if either of the > two respective features is available, MPX continues to get exposed to > guests only with both features present. > > Also add the so far missing handling of > - GUEST_BNDCFGS in construct_vmcs() > - MSR_IA32_BNDCFGS in vmx_msr_{read,write}_intercept() > and mirror the extra correctness checks during MSR write to > vmx_load_msr(). > > Reported-by: "Rockosov, Dmitry" > Signed-off-by: Jan Beulich > Tested-by: "Rockosov, Dmitry" Reviewed-by: Andrew Cooper --------------821F4887DC60C46DC6534758 Content-Type: text/html; charset="windows-1252" Content-Transfer-Encoding: 7bit
On 02/09/16 11:21, Jan Beulich wrote:
Their VMCS fields aren't tied to the respective base CPU feature flags
but instead to VMX specific ones.

Note that while the VMCS GUEST_BNDCFGS field exists if either of the
two respective features is available, MPX continues to get exposed to
guests only with both features present.

Also add the so far missing handling of
- GUEST_BNDCFGS in construct_vmcs()
- MSR_IA32_BNDCFGS in vmx_msr_{read,write}_intercept()
and mirror the extra correctness checks during MSR write to
vmx_load_msr().

Reported-by: "Rockosov, Dmitry" <dmitry.rockosov@intel.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Tested-by: "Rockosov, Dmitry" <dmitry.rockosov@intel.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
--------------821F4887DC60C46DC6534758-- --===============7861923547129274712== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7861923547129274712==--