xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Bennieston <andrew.bennieston@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	ian.campbell@citrix.com, xen-devel@lists.xen.org,
	annie.li@oracle.com, msw@amazon.com
Subject: Re: [PATCH V4 0/3] xen-netback: switch to NAPI + kthread 1:1 model
Date: Tue, 6 Aug 2013 15:17:46 +0100	[thread overview]
Message-ID: <5201058A.4070307@citrix.com> (raw)
In-Reply-To: <5200FA3A.4030704@citrix.com>

On 06/08/13 14:29, David Vrabel wrote:
> On 06/08/13 14:16, Pasi Kärkkäinen wrote:
>> On Tue, Aug 06, 2013 at 10:06:00AM +0100, Wei Liu wrote:
>>>
>>> IRQs are distributed to 4 cores by hand in the new model, while in the
>>> old model vifs are automatically distributed to 4 kthreads.
>>>
>>
>> Hmm.. so with these patches applied is is *required* to do manual configuration in dom0 to get good performance?
>
> This should be irqbalanced's job.  The existing version doesn't do a
> good enough job yet though.  Andrew Bennieston may have more details.
>
> David
>

irqbalance 1.0.6 [1] includes a patch [2] from Wei Liu [3] that adds
support for balancing `xen-dyn-event' interrupts. When I have compiled
this version and run it under Xen(Server) I noticed that the
interrupts are indeed moving between cores, but not necessarily in
what I would call an obvious or optimal way (e.g. several VIF
interrupts are being grouped onto a single dom0 VCPU at times). I plan
on investigating this further when time permits.

I also noticed that, from time to time, the irqbalance process
disappears. I tracked this down to a segfault that occurs when a VM
shuts down and an IRQ disappears during one of irqbalance's periodic
rescans. I'm hoping to be able to narrow this down sufficiently to
identify the cause and ideally fix it, but I don't have a lot of time
to work on this at the moment.

As for the impact on Wei's patches, without irqbalance it would be
trivial to automatically assign (via a script, on VM start) the
interrupts for a particular VIF to a particular dom0 vCPU in a
round-robin fashion, just as VIFs were previously assigned to netback
kthreads. This would result in broadly the same performance as before,
while an improved irqbalanced should give better performance and
fairness when two different VIFs would otherwise be competing for the
same resources.

Andrew.

[1] https://code.google.com/p/irqbalance/downloads
[2] 
https://code.google.com/p/irqbalance/source/detail?r=736a91b739018530c44e59d9b17252f88227fe51
[3] https://code.google.com/p/irqbalance/issues/detail?id=46

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-08-06 14:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06  9:06 [PATCH V4 0/3] xen-netback: switch to NAPI + kthread 1:1 model Wei Liu
2013-08-06  9:06 ` [PATCH V4 1/3] xen-netback: remove page tracking facility Wei Liu
2013-08-07  2:52   ` Matt Wilson
2013-08-06  9:06 ` [PATCH V4 2/3] xen-netback: switch to NAPI + kthread 1:1 model Wei Liu
2013-08-06 13:33   ` Wei Liu
2013-08-06 13:50     ` Ian Campbell
2013-08-06 14:50       ` Wei Liu
2013-08-06 14:56         ` Ian Campbell
2013-08-06 15:05           ` Wei Liu
2013-08-06 15:21             ` Ian Campbell
2013-08-06 15:24               ` Wei Liu
2013-08-06 15:33                 ` Wei Liu
2013-08-06 15:38                   ` Ian Campbell
2013-08-06 15:47                     ` Wei Liu
2013-08-06 15:50                       ` Ian Campbell
2013-08-06 15:54                         ` Wei Liu
2013-08-06 15:58                           ` Ian Campbell
2013-08-06  9:06 ` [PATCH V4 3/3] xen-netback: rename functions Wei Liu
2013-08-06 13:16 ` [PATCH V4 0/3] xen-netback: switch to NAPI + kthread 1:1 model Pasi Kärkkäinen
2013-08-06 13:28   ` Wei Liu
2013-08-06 13:29   ` David Vrabel
2013-08-06 14:17     ` Andrew Bennieston [this message]
2013-08-22 15:12       ` Wei Liu
2013-08-22 15:19         ` Wei Liu
2013-08-22 17:14         ` Matt Wilson
2013-08-23  2:24         ` annie li
2013-08-15 13:20 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5201058A.4070307@citrix.com \
    --to=andrew.bennieston@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=msw@amazon.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).