Re: [PATCH 4/5] xen/arm: Introduce platform recognition codes for the OMAP5

[Julien Grall <julien.grall@linaro.org>]

On 08/07/2013 04:24 AM, Chen Baozi wrote:
> 
> On Aug 7, 2013, at 6:00 AM, Julien Grall <julien.grall@linaro.org> wrote:
> 
>> On 5 August 2013 12:49, Chen Baozi <baozich@gmail.com> wrote:
>>> Signed-off-by: Chen Baozi <baozich@gmail.com>
>>> ---
>>> xen/arch/arm/platforms/Makefile       |  1 +
>>> xen/arch/arm/platforms/omap5.c        | 41 +++++++++++++++++++++++++++++++++++
>>> xen/include/asm-arm/platforms/omap5.h | 23 ++++++++++++++++++++
>>> 3 files changed, 65 insertions(+)
>>> create mode 100644 xen/arch/arm/platforms/omap5.c
>>> create mode 100644 xen/include/asm-arm/platforms/omap5.h
>>>
>>> diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
>>> index ff2b65b..90ddcb1 100644
>>> --- a/xen/arch/arm/platforms/Makefile
>>> +++ b/xen/arch/arm/platforms/Makefile
>>> @@ -1,2 +1,3 @@
>>> obj-y += vexpress.o
>>> obj-y += exynos5.o
>>> +obj-y += omap5.o
>>> diff --git a/xen/arch/arm/platforms/omap5.c b/xen/arch/arm/platforms/omap5.c
>>> new file mode 100644
>>> index 0000000..eecf35b
>>> --- /dev/null
>>> +++ b/xen/arch/arm/platforms/omap5.c
>>> @@ -0,0 +1,41 @@
>>> +/*
>>> + * xen/arch/arm/platforma/omap5.c
>>> + *
>>> + * OMAP5 specific settings
>>> + *
>>> + * Chen Baozi <baozich@gmail.com>
>>> + * Copyright (c) 2013
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributted in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> + * GNU Gerneral Public License for more details.
>>> + */
>>> +
>>> +#include <xen/config.h>
>>> +#include <asm/platforms/omap5.h>
>>> +#include <asm/platform.h>
>>> +
>>> +static const char const *omap5_dt_compat[] __initdata =
>>> +{
>>> +    "ti,omap5",
>>> +    NULL
>>> +};
>>> +
>>> +PLATFORM_START(omap5, "TI OMAP5")
>>> +    .compatible = omap5_dt_compat,
>>> +PLATFORM_END
>>> +
>>> +/*
>>> + * Local variables:
>>> + * mode: C
>>> + * c-file-style: "BSD"
>>> + * c-basic-offset: 4
>>> + * indent-tabs-mode: nil
>>> + * End:
>>> + */
>>> diff --git a/xen/include/asm-arm/platforms/omap5.h b/xen/include/asm-arm/platforms/omap5.h
>>> new file mode 100644
>>> index 0000000..fa825b7
>>> --- /dev/null
>>> +++ b/xen/include/asm-arm/platforms/omap5.h
>>> @@ -0,0 +1,23 @@
>>> +#ifndef __ASM_ARM_PLATFORMS_OMAP5_H
>>> +#define __ASM_ASM_PLATFORMS_OMAP5_H
>>> +
>>> +/* Constants below is only used in assembly because the DTS is not yet parsed */
>>> +#ifdef __ASSEMBLY__
>>> +
>>> +/* GIC Base Address */
>>> +#define OMAP5_GIC_BASE_ADDRESS                0x48210000
>>> +
>>> +/* OMAP5432 uEVM machine ID */
>>> +#define MACH_TYPE_UEVM                        3777
>>
>> These 2 values seems unused in your patch series. Do you plan to use
>> it in the future?
> 
> Yes, it will be used in SMP boot codes, which I'm now working on.
> Or, should I add this macros in the SMP boot patch?

I would prefer, if you define these macros in the SMP boot patch.

-- 
Julien