From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 2/2] xen/arm: errata 766422: decode thumb
 store during data abort
Date: Thu, 08 Aug 2013 13:04:24 +0100
Message-ID: <52038948.20104@linaro.org>
References: <1375813878-21435-1-git-send-email-julien.grall@linaro.org>
	<1375813878-21435-3-git-send-email-julien.grall@linaro.org>
	<1375960179.970.69.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1375960179.970.69.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, patches@linaro.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 08/08/2013 12:09 PM, Ian Campbell wrote:
> On Tue, 2013-08-06 at 19:31 +0100, Julien Grall wrote:
>> +    /*
>> +     * Errata 766422: Thumb store translation fault to Hypervisor may
>> +     * not have correct HSR Rt value.
>> +     */
>> +    if ( cpu_has_errata_766422() && (regs->cpsr & PSR_THUMB) && dabt.write )
>> +    {
>> +        rc = decode_instruction(regs, &info.dabt);
>> +        if ( rc )
>> +            goto bad_data_abort;
> 
> Consider logging here so we know which caller of decode_instruction
> failed?

I will add a printk.

> Either way:
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Ian.
> 


-- 
Julien Grall