From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 2/5] xen/arm: add 8250 compatible UART support for early_printk Date: Thu, 08 Aug 2013 13:06:48 +0100 Message-ID: <520389D8.2080101@linaro.org> References: <1375959145-13709-1-git-send-email-baozich@gmail.com> <1375959145-13709-3-git-send-email-baozich@gmail.com> <1375961652.970.79.camel@kazak.uk.xensource.com> <1375961791.970.80.camel@kazak.uk.xensource.com> <6282899A-78C3-4132-8DD7-EA3C1A925E57@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6282899A-78C3-4132-8DD7-EA3C1A925E57@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chen Baozi Cc: Xen Developer List , Ian Campbell , Bamvor Jian Zhang List-Id: xen-devel@lists.xenproject.org On 08/08/2013 01:04 PM, Chen Baozi wrote: > > On Aug 8, 2013, at 7:36 PM, Ian Campbell wrote: > >> On Thu, 2013-08-08 at 12:34 +0100, Ian Campbell wrote: >> >>>> diff --git a/xen/include/xen/8250-uart.h b/xen/include/xen/8250-uart.h >>>> index 7287364..33daa6d 100644 >>>> --- a/xen/include/xen/8250-uart.h >>>> +++ b/xen/include/xen/8250-uart.h >>>> @@ -22,6 +22,10 @@ >>>> #ifndef __XEN_8250_UART_H__ >>>> #define __XEN_8250_UART_H__ >>>> >>>> +#ifdef CONFIG_ARM >>>> +#define REG_SHIFT 2 >>>> +#endif >>> >>> I think this should actually be part of the per-platform early-printk >>> block, e.g. EARLY_UART_REG_SHIFT >> >> I should have also said that for non-early drivers this should come from >> the device tree. >> >> Possibly in the case of your OMAP speciifc driver it could be hardcoded, >> but only if it isn't in DT IMHO. > > It seems OMAP5's DT doesn't have this info? Does exynos5 have it? Exynos5 uses a different UART which doesn't need shift. -- Julien Grall