From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] VMX, apicv: add boot parameter to enable/disable APIC-v dynamically Date: Fri, 9 Aug 2013 10:42:55 +0100 Message-ID: <5204B99F.5070109@citrix.com> References: <1376038886-18645-1-git-send-email-yang.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1376038886-18645-1-git-send-email-yang.z.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Zhang Cc: xen-devel@lists.xensource.com, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 09/08/13 10:01, Yang Zhang wrote: > From: Yang Zhang > > Add a boot parameter to enable/disable the APIC-v dynamically. APIC-v is > enabled by default. User can use apicv=0 to disable it. > > Signed-off-by: Yang Zhang > --- Please patch docs/misc/xen-command-line.markdown as well. > xen/arch/x86/hvm/vmx/vmcs.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > index de9f592..b52408d 100644 > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -46,6 +46,9 @@ boolean_param("vpid", opt_vpid_enabled); > static bool_t __read_mostly opt_unrestricted_guest_enabled = 1; > boolean_param("unrestricted_guest", opt_unrestricted_guest_enabled); > > +static bool_t __read_mostly opt_apicv_enabled = 1; > +boolean_param("apicv", opt_apicv_enabled); > + > /* > * These two parameters are used to config the controls for Pause-Loop Exiting: > * ple_gap: upper bound on the amount of time between two successive > @@ -196,12 +199,12 @@ static int vmx_init_vmcs_config(void) > * "APIC Register Virtualization" and "Virtual Interrupt Delivery" > * can be set only when "use TPR shadow" is set > */ > - if ( _vmx_cpu_based_exec_control & CPU_BASED_TPR_SHADOW ) > + if ( _vmx_cpu_based_exec_control & CPU_BASED_TPR_SHADOW && > + opt_apicv_enabled ) > opt |= SECONDARY_EXEC_APIC_REGISTER_VIRT | > SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY | > SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; > > - Unrelated whitespace alteration. ~Andrew > _vmx_secondary_exec_control = adjust_vmx_controls( > "Secondary Exec Control", min, opt, > MSR_IA32_VMX_PROCBASED_CTLS2, &mismatch);