From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools/ia64: Cull more ia64 code Date: Tue, 13 Aug 2013 14:13:28 +0100 Message-ID: <520A30F8.1070707@citrix.com> References: <1376398809-7962-1-git-send-email-andrew.cooper3@citrix.com> <520A4C3C02000078000EB8A0@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1V9EPq-0007QI-SY for xen-devel@lists.xenproject.org; Tue, 13 Aug 2013 13:13:39 +0000 In-Reply-To: <520A4C3C02000078000EB8A0@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 13/08/13 14:09, Jan Beulich wrote: >>>> On 13.08.13 at 15:00, Andrew Cooper wrote: >> --- a/tools/libfsimage/common/fsimage_grub.c >> +++ b/tools/libfsimage/common/fsimage_grub.c >> @@ -138,28 +138,6 @@ fsig_log2 (unsigned long word) >> return word; >> } >> >> -#elif defined(__ia64__) >> - >> -#if __GNUC__ >= 4 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4) >> -# define ia64_popcnt(x) __builtin_popcountl(x) >> -#else >> -# define ia64_popcnt(x) \ >> - ({ \ >> - uint64_t ia64_intri_res; \ >> - asm ("popcnt %0=%1" : "=r" (ia64_intri_res) : "r" (x)); \ >> - ia64_intri_res; \ >> - }) >> -#endif >> - >> -unsigned long >> -fsig_log2 (unsigned long word) >> -{ >> - unsigned long result; >> - >> - result = ia64_popcnt((word - 1) & ~word); >> - return result; >> -} >> - >> #elif defined(__powerpc__) >> >> #ifdef __powerpc64__ > Why not rip out the PPC stuff here at once? > > Jan > Can do - this appears to be the only ppc which can be ripped out. v2 on its way ~Andrew