From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 3/3] libxc: add xc_tbuf_trace() to insert
	trace records
Date: Thu, 15 Aug 2013 15:39:09 +0100
Message-ID: <520CE80D.5030500@citrix.com>
References: <1374758582-29038-1-git-send-email-david.vrabel@citrix.com>
	<1374758582-29038-4-git-send-email-david.vrabel@citrix.com>
	<520CE796.1090603@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <520CE796.1090603@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 15/08/13 15:37, George Dunlap wrote:
> On 25/07/13 14:23, David Vrabel wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> Add xc_tbuf_trace() to allow trace records to be added to the trace
>> buffer.  The subclass and event number and up to 7 uin32_t arguments
>> may be specified.
>>
>> The hypercall sub-op used is HVMOP_xentrace which (despite the name)
>> may be used by PV guests.
> 
> Would it make sense to make this interface more like the hypervisor's
> trace_var() -- that is, taking a sizeof() and single pointer, so that
> callers can easily pass in packed structs?

I did it like this so it would only take a single line to get a useful
trace point.

David