From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 0/3] stdinc-related build fixes.
Date: Thu, 15 Aug 2013 20:58:44 +0100
Message-ID: <520D32F4.1040200@citrix.com>
References: <1376573107-27249-1-git-send-email-tim@xen.org>
	<20130815194936.GA138@quantz>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130815194936.GA138@quantz>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Patrick Welche <prlw1@cam.ac.uk>
Cc: keir@xen.org, ian.campbell@citrix.com, Tim Deegan <tim@xen.org>, chegger@amazon.de, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 15/08/13 20:49, Patrick Welche wrote:
> On Thu, Aug 15, 2013 at 02:25:04PM +0100, Tim Deegan wrote:
>> These three patches tidy some of the xen build runes around the use of
>> nostdinc.
>>
>> Patch 3/3 hasn't yet been tested on an actual NetBSD box,
>> so I'd appreciate it if Patrick would give it a go.  Apart from that,
>> I've tested with every GCC I can lay my hands on (and clang 3.0),
>> building x86 and ARM.
> Your changes allowed a successful "gmake xen", thank you!
>
> If we want to carry on helping smooth out the build, I was surprised
> by "gmake install xen" giving
>
>   [ -d //boot ] || install -d -m0755 -p //boot
>   install: //boot exists but is not a directory
>
> given that I had configured with --prefix=/usr/local/xen.
>
> /boot isn't a directory, it's my second stage bootloader, so I
> would rather not loose it ;-) Start another thread?
>
> Cheers,
>
> Patrick

As for your boot problem, that will be something not correctly setting
the DESTDIR make variable.

Is gmake having a fit with the "local variable" syntax in xen/Makefile

.PHONY: _install
_install: D=$(DESTDIR)
_install: T=$(notdir $(TARGET))
_install: Z=$(CONFIG_XEN_INSTALL_SUFFIX)
_install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
        [ -d $(D)/boot ] || $(INSTALL_DIR) $(D)/boot
        $(INSTALL_DATA) $(TARGET)$(Z) $(D)/boot/$(T)-$(XEN_FULLVERSION)$(Z)

or is something else not setting DESTDIR higher up?

~Andrew

>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel